NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

Commit120bc4b

authored

refactor(site): Only show status after first edition (#6701)

1 parent7e854ad commit120bc4bCopy full SHA for 120bc4b

File tree

1 file changed

-5

lines changed

site/src/components/TemplateVersionEditor
- TemplateVersionEditor.tsx

1 file changed

-5

lines changed

`‎site/src/components/TemplateVersionEditor/TemplateVersionEditor.tsx`

Lines changed: 9 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({`
`89`	`89`	`const[createFileOpen,setCreateFileOpen]=useState(false)`
`90`	`90`	`const[deleteFileOpen,setDeleteFileOpen]=useState<string>()`
`91`	`91`	`const[renameFileOpen,setRenameFileOpen]=useState<string>()`
	`92`	`+const[dirty,setDirty]=useState(false)`
`92`	`93`	`const[activePath,setActivePath]=useState<string\|undefined>(()=>`
`93`	`94`	`findInitialFile(fileTree),`
`94`	`95`	`)`
`@@ -139,11 +140,11 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({`
`139`	`140`	`previousVersion.current=templateVersion`
`140`	`141`	`},[templateVersion])`
`141`	`142`
`142`		`-const[dirty,setDirty]=useState(false)`
`143`	`143`	`consthasIcon=template.icon&&template.icon!==""`
`144`	`144`	`consttemplateVersionSucceeded=templateVersion.job.status==="succeeded"`
`145`	`145`	`constshowBuildLogs=Boolean(buildLogs)`
`146`	`146`	`consteditorValue=getFileContent(activePath??"",fileTree)asstring`
	`147`	`+constfirstTemplateVersionOnEditor=useRef(templateVersion)`
`147`	`148`
`148`	`149`	`useEffect(()=>{`
`149`	`150`	`window.dispatchEvent(newEvent("resize"))`
`@@ -170,9 +171,12 @@ export const TemplateVersionEditor: FC<TemplateVersionEditorProps> = ({`
`170`	`171`	`</div>`
`171`	`172`
`172`	`173`	`<divclassName={styles.topbarSides}>`
`173`		`-<divclassName={styles.buildStatus}>`
`174`		`-<TemplateVersionStatusBadgeversion={templateVersion}/>`
`175`		`-</div>`
	`174`	`+{/* Only start to show the build when a new template version is building */}`
	`175`	`+{templateVersion.id!==firstTemplateVersionOnEditor.current.id&&(`
	`176`	`+<divclassName={styles.buildStatus}>`
	`177`	`+<TemplateVersionStatusBadgeversion={templateVersion}/>`
	`178`	`+</div>`
	`179`	`+)}`
`176`	`180`
`177`	`181`	`<Button`
`178`	`182`	`title="Build template (Ctrl + Enter)"`
`@@ -387,7 +391,7 @@ const useStyles = makeStyles<`
`387`	`391`	`{`
`388`	`392`	`templateVersionSucceeded:boolean`
`389`	`393`	`showBuildLogs:boolean`
`390`		`-deploymentBannerVisible:boolean`
	`394`	`+deploymentBannerVisible?:boolean`
`391`	`395`	`}`
`392`	`396`	`>((theme)=>({`
`393`	`397`	`root:{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit120bc4b

File tree

1 file changed

1 file changed

`‎site/src/components/TemplateVersionEditor/TemplateVersionEditor.tsx`

0 commit comments