Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit10aa32c

Browse files
authored
chore: refactorAgentHasNotConnectedSinceWeek_LogsExpired (#13802)
1 parentfecc5b3 commit10aa32c

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

‎coderd/database/dbpurge/dbpurge_test.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"time"
1212

1313
"github.com/google/uuid"
14+
"github.com/stretchr/testify/assert"
1415
"github.com/stretchr/testify/require"
1516
"go.uber.org/goleak"
1617
"golang.org/x/exp/slices"
@@ -183,20 +184,29 @@ func TestDeleteOldWorkspaceAgentLogs(t *testing.T) {
183184
// given
184185
agent:=mustCreateAgentWithLogs(ctx,t,db,user,org,tmpl,tv,now.Add(-8*24*time.Hour),t.Name())
185186

187+
// Make sure that agent logs have been collected.
188+
agentLogs,err:=db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
189+
AgentID:agent,
190+
})
191+
require.NoError(t,err)
192+
require.NotZero(t,agentLogs,"agent logs must be present")
193+
186194
// when
187195
closer:=dbpurge.New(ctx,logger,db)
188196
defercloser.Close()
189197

190198
// then
191-
require.Eventually(t,func()bool {
192-
agentLogs,err:=db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
199+
assert.Eventually(t,func()bool {
200+
agentLogs,err=db.GetWorkspaceAgentLogsAfter(ctx, database.GetWorkspaceAgentLogsAfterParams{
193201
AgentID:agent,
194202
})
195203
iferr!=nil {
196204
returnfalse
197205
}
198206
return!containsAgentLog(agentLogs,t.Name())
199207
},testutil.WaitShort,testutil.IntervalFast)
208+
require.NoError(t,err)
209+
require.NotContains(t,agentLogs,t.Name())
200210
})
201211

202212
t.Run("AgentConnectedSixDaysAgo_LogsValid",func(t*testing.T) {

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp