Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0f44048

Browse files
authored
fix: adjust ParameterSchema type for workspace creation (#2384)
* add ability to activate usersresolves#2254* added test* PR feedback* guarding against null validation_contains field* fixing type for ParameterSchemaresolves#2161
1 parent2e625c1 commit0f44048

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

‎codersdk/parameters.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ type ParameterSchema struct {
7272

7373
// This is a special array of items provided if the validation condition
7474
// explicitly states the value must be one of a set.
75-
ValidationContains []string`json:"validation_contains"`
75+
ValidationContains []string`json:"validation_contains,omitempty"`
7676
}
7777

7878
// CreateParameterRequest is used to create a new parameter value for a scope.

‎site/src/api/typesGenerated.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ export interface ParameterSchema {
190190
readonlyvalidation_condition:string
191191
readonlyvalidation_type_system:string
192192
readonlyvalidation_value_type:string
193-
readonlyvalidation_contains:string[]
193+
readonlyvalidation_contains?:string[]
194194
}
195195

196196
// From codersdk/provisionerdaemons.go:33:6

‎site/src/components/ParameterInput/ParameterInput.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export const ParameterInput: FC<ParameterInputProps> = ({ disabled, onChange, sc
2929
}
3030

3131
constParameterField:React.FC<ParameterInputProps>=({ disabled, onChange, schema})=>{
32-
if(schema.validation_contains.length>0){
32+
if(schema.validation_contains&&schema.validation_contains.length>0){
3333
return(
3434
<RadioGroup
3535
defaultValue={schema.default_source_value}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp