Commit0dd2c9d

authored and

committed

fix: prevent dbmem reading other groups when getting group members (#14581)

1 parent23792bf commit0dd2c9dCopy full SHA for 0dd2c9d

File tree

-7

lines changed

-7

lines changed

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -2663,14 +2663,14 @@ func (q *FakeQuerier) GetGroupMembersByGroupID(ctx context.Context, id uuid.UUID`
`2663`	`2663`
`2664`	`2664`	`vargroupMembers []database.GroupMember`
`2665`	`2665`	`for_,member:=rangeq.groupMembers {`
`2666`		`-groupMember,err:=q.getGroupMemberNoLock(ctx,member.UserID,member.GroupID)`
`2667`		`-iferrors.Is(err,errUserDeleted) {`
`2668`		`-continue`
`2669`		`-}`
`2670`		`-iferr!=nil {`
`2671`		`-returnnil,err`
`2672`		`-}`
`2673`	`2666`	`ifmember.GroupID==id {`
	`2667`	`+groupMember,err:=q.getGroupMemberNoLock(ctx,member.UserID,member.GroupID)`
	`2668`	`+iferrors.Is(err,errUserDeleted) {`
	`2669`	`+continue`
	`2670`	`+}`
	`2671`	`+iferr!=nil {`
	`2672`	`+returnnil,err`
	`2673`	`+}`
`2674`	`2674`	`groupMembers=append(groupMembers,groupMember)`
`2675`	`2675`	`}`
`2676`	`2676`	`}`

Comments

(0)