Commit0db909c

committed

fix: close pg PubSub listener to avoid race

1 parent5bfbf9f commit0db909cCopy full SHA for 0db909c

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -239,8 +239,11 @@ func (p *pgPubsub) Publish(event string, message []byte) error {`
`239`	`239`
`240`	`240`	`// Close closes the pubsub instance.`
`241`	`241`	`func (p*pgPubsub)Close()error {`
`242`		`-p.cancel()`
	`242`	`+// canceling the context also causes the listener to be closed, so directly`
	`243`	`+// close it before canceling the context to avoid the race. If we lost the`
	`244`	`+// race we'd return an error about the listener already being closed.`
`243`	`245`	`err:=p.pgListener.Close()`
	`246`	`+p.cancel()`
`244`	`247`	`<-p.listenDone`
`245`	`248`	`returnerr`
`246`	`249`	`}`

Comments

(0)