Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0d9d751

Browse files
committed
refactor: improve preset selection logic in workspace creation
Replace findIndex with find() to avoid -1 edge case and consolidate preset initialization into single useEffect for better maintainability.Signed-off-by: Danny Kopping <dannykopping@gmail.com>
1 parent83192a7 commit0d9d751

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

‎site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -152,32 +152,31 @@ export const CreateWorkspacePageView: FC<CreateWorkspacePageViewProps> = ({
152152
const[presetOptions,setPresetOptions]=useState([
153153
{label:"None",value:""},
154154
]);
155+
const[selectedPresetIndex,setSelectedPresetIndex]=useState(0);
156+
// Build options and keep default label/value in sync
155157
useEffect(()=>{
156-
setPresetOptions([
158+
constoptions=[
157159
{label:"None",value:""},
158-
...presets.map((preset)=>({
159-
label:preset.Default ?`${preset.Name} (Default)` :preset.Name,
160-
value:preset.ID,
160+
...presets.map((p)=>({
161+
label:p.Default ?`${p.Name} (Default)` :p.Name,
162+
value:p.ID,
161163
})),
162-
]);
163-
},[presets]);
164-
165-
const[selectedPresetIndex,setSelectedPresetIndex]=useState(0);
166-
167-
// Set default preset when presets are loaded
168-
useEffect(()=>{
169-
constdefaultPreset=presets.find((preset)=>preset.Default);
164+
];
165+
setPresetOptions(options);
166+
constdefaultPreset=presets.find((p)=>p.Default);
170167
if(defaultPreset){
171-
// +1 because "None" is at index 0
172-
constdefaultIndex=
173-
presets.findIndex((preset)=>preset.ID===defaultPreset.ID)+1;
174-
setSelectedPresetIndex(defaultIndex);
168+
constidx=presets.indexOf(defaultPreset)+1;// +1 for "None"
169+
setSelectedPresetIndex(idx);
170+
form.setFieldValue("template_version_preset_id",defaultPreset.ID);
171+
}else{
172+
setSelectedPresetIndex(0);// Explicitly set to "None"
173+
form.setFieldValue("template_version_preset_id","");
175174
}
176-
},[presets]);
175+
},[presets,form.setFieldValue]);
176+
177177
const[presetParameterNames,setPresetParameterNames]=useState<string[]>(
178178
[],
179179
);
180-
181180
useEffect(()=>{
182181
constselectedPresetOption=presetOptions[selectedPresetIndex];
183182
letselectedPreset:TypesGen.Preset|undefined;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp