Commit0d53795

authored

feat: Add strict transport security and secure cookie options (#741)

1 parentbb6c12d commit0d53795Copy full SHA for 0d53795

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ func start() *cobra.Command {`
`56`	`56`	`tlsMinVersionstring`
`57`	`57`	`useTunnelbool`
`58`	`58`	`traceDatadogbool`
	`59`	`+secureAuthCookiebool`
`59`	`60`	`)`
`60`	`61`	`root:=&cobra.Command{`
`61`	`62`	`Use:"start",`
`@@ -132,6 +133,7 @@ func start() *cobra.Command {`
`132`	`133`	`Database:databasefake.New(),`
`133`	`134`	`Pubsub:database.NewPubsubInMemory(),`
`134`	`135`	`GoogleTokenValidator:validator,`
	`136`	`+SecureAuthCookie:secureAuthCookie,`
`135`	`137`	`}`
`136`	`138`
`137`	`139`	`if!dev {`
`@@ -334,6 +336,7 @@ func start() *cobra.Command {`
`334`	`336`	`cliflag.BoolVarP(root.Flags(),&useTunnel,"tunnel","","CODER_DEV_TUNNEL",true,"Serve dev mode through a Cloudflare Tunnel for easy setup")`
`335`	`337`	`_=root.Flags().MarkHidden("tunnel")`
`336`	`338`	`cliflag.BoolVarP(root.Flags(),&traceDatadog,"trace-datadog","","CODER_TRACE_DATADOG",false,"Send tracing data to a datadog agent")`
	`339`	`+cliflag.BoolVarP(root.Flags(),&secureAuthCookie,"secure-auth-cookie","","CODER_SECURE_AUTH_COOKIE",false,"Specifies if the 'Secure' property is set on browser session cookies")`
`337`	`340`
`338`	`341`	`returnroot`
`339`	`342`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,8 @@ type Options struct {`
`29`	`29`
`30`	`30`	`AWSCertificates awsidentity.Certificates`
`31`	`31`	`GoogleTokenValidator*idtoken.Validator`
	`32`	`+`
	`33`	`+SecureAuthCookiebool`
`32`	`34`	`}`
`33`	`35`
`34`	`36`	`// New constructs the Coder API into an HTTP handler.`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -417,6 +417,7 @@ func (api api) postLogin(rw http.ResponseWriter, r http.Request) {`
`417`	`417`	`Path:"/",`
`418`	`418`	`HttpOnly:true,`
`419`	`419`	`SameSite:http.SameSiteLaxMode,`
	`420`	`+Secure:api.SecureAuthCookie,`
`420`	`421`	`})`
`421`	`422`
`422`	`423`	`render.Status(r,http.StatusCreated)`

Comments

(0)