Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit0bc49ff

Browse files
authored
test: fix flake in TestRoleSyncTable with test cases sharing resources (#17441)
The test case definition shares maps that can have concurrent access if run in parallel.
1 parent7f6e513 commit0bc49ff

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

‎coderd/idpsync/role_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,8 @@ func TestRoleSyncTable(t *testing.T) {
225225
// deployment. This tests all organizations being synced together.
226226
// The reason we do them individually, is that it is much easier to
227227
// debug a single test case.
228+
//nolint:paralleltest, tparallel // This should run after all the individual tests
228229
t.Run("AllTogether",func(t*testing.T) {
229-
t.Parallel()
230-
231230
db,_:=dbtestutil.NewDB(t)
232231
manager:=runtimeconfig.NewManager()
233232
s:=idpsync.NewAGPLSync(slogtest.Make(t,&slogtest.Options{

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp