Commit0a95ba6

authored

chore: Deprecate old cookie value (#4336)

Older clis will need to be updated.Modern clis cannot communicate with <8.15 coderd

1 parent4f63555 commit0a95ba6Copy full SHA for 0a95ba6

File tree

-15

lines changed

-15

lines changed

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -380,14 +380,6 @@ func apiTokenFromRequest(r *http.Request) string {`
`380`	`380`	`returncookie.Value`
`381`	`381`	`}`
`382`	`382`
`383`		`-// TODO: @emyrk in October 2022, remove this oldCookie check.`
`384`		`-//This is just to support the old cli for 1 release. Then everyone`
`385`		`-//must update.`
`386`		`-oldCookie,err:=r.Cookie("session_token")`
`387`		`-iferr==nil&&oldCookie.Value!="" {`
`388`		`-returnoldCookie.Value`
`389`		`-}`
`390`		`-`
`391`	`383`	`urlValue:=r.URL.Query().Get(codersdk.SessionTokenKey)`
`392`	`384`	`ifurlValue!="" {`
`393`	`385`	`returnurlValue`

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -83,13 +83,6 @@ func (c *Client) Request(ctx context.Context, method, path string, body interfac`
`83`	`83`	`}`
`84`	`84`	`req.Header.Set(SessionCustomHeader,c.SessionToken)`
`85`	`85`
`86`		`-// Delete this custom cookie set in November 2022. This is just to remain`
`87`		`-// backwards compatible with older versions of Coder.`
`88`		`-req.AddCookie(&http.Cookie{`
`89`		`-Name:"session_token",`
`90`		`-Value:c.SessionToken,`
`91`		`-})`
`92`		`-`
`93`	`86`	`ifbody!=nil {`
`94`	`87`	`req.Header.Set("Content-Type","application/json")`
`95`	`88`	`}`

Comments

(0)