Commit0a5e554

authored

fix:time.NewTicker leaks (#4630)

1 parent5d7d8c3 commit0a5e554Copy full SHA for 0a5e554

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,10 @@ func NewWorkspaceAppHealthReporter(logger slog.Logger, workspaceAgentApps Worksp`
`60`	`60`	`continue`
`61`	`61`	`}`
`62`	`62`	`app:=nextApp`
`63`		`-t:=time.NewTicker(time.Duration(app.Healthcheck.Interval)*time.Second)`
`64`	`63`	`gofunc() {`
	`64`	`+t:=time.NewTicker(time.Duration(app.Healthcheck.Interval)*time.Second)`
	`65`	`+defert.Stop()`
	`66`	`+`
`65`	`67`	`for {`
`66`	`68`	`select {`
`67`	`69`	`case<-ctx.Done():`
`@@ -118,6 +120,7 @@ func NewWorkspaceAppHealthReporter(logger slog.Logger, workspaceAgentApps Worksp`
`118`	`120`	`lastHealth:=copyHealth(health)`
`119`	`121`	`mu.Unlock()`
`120`	`122`	`reportTicker:=time.NewTicker(time.Second)`
	`123`	`+deferreportTicker.Stop()`
`121`	`124`	`// every second we check if the health values of the apps have changed`
`122`	`125`	`// and if there is a change we will report the new values.`
`123`	`126`	`for {`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ func TestDERPMesh(t *testing.T) {`
`74`	`74`	`gofunc() {`
`75`	`75`	`deferclose(closed)`
`76`	`76`	`ticker:=time.NewTicker(50*time.Millisecond)`
	`77`	`+deferticker.Stop()`
`77`	`78`	`for {`
`78`	`79`	`select {`
`79`	`80`	`case<-ctx.Done():`
`@@ -118,6 +119,7 @@ func TestDERPMesh(t *testing.T) {`
`118`	`119`	`gofunc() {`
`119`	`120`	`deferclose(closed)`
`120`	`121`	`ticker:=time.NewTicker(50*time.Millisecond)`
	`122`	`+deferticker.Stop()`
`121`	`123`	`for {`
`122`	`124`	`select {`
`123`	`125`	`case<-ctx.Done():`
`@@ -169,6 +171,7 @@ func TestDERPMesh(t *testing.T) {`
`169`	`171`	`gofunc() {`
`170`	`172`	`deferclose(closed)`
`171`	`173`	`ticker:=time.NewTicker(50*time.Millisecond)`
	`174`	`+deferticker.Stop()`
`172`	`175`	`for {`
`173`	`176`	`select {`
`174`	`177`	`case<-ctx.Done():`

Comments

(0)