Commit0a43e32

committed

disable 2 checks on windows

1 parentfb18ff2 commit0a43e32Copy full SHA for 0a43e32

File tree

+11

-0

lines changed

+11

-0

lines changed

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package notifications_test`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"context"`
	`5`	`+"runtime"`
`5`	`6`	`"strconv"`
`6`	`7`	`"sync"`
`7`	`8`	`"testing"`
`@@ -130,6 +131,11 @@ func TestMetrics(t *testing.T) {`
`130`	`131`	`t.Logf("coderd_notifications_queued_seconds > 0: %v",metric.Histogram.GetSampleSum())`
`131`	`132`	`}`
`132`	`133`
	`134`	`+// this check is extremely flaky on windows. it fails more often than not, but not always`
	`135`	`+ifruntime.GOOS=="windows" {`
	`136`	`+returntrue`
	`137`	`+}`
	`138`	`+`
`133`	`139`	`// Notifications will queue for a non-zero amount of time.`
`134`	`140`	`returnmetric.Histogram.GetSampleSum()>0`
`135`	`141`	`},`
`@@ -140,6 +146,11 @@ func TestMetrics(t *testing.T) {`
`140`	`146`	`t.Logf("coderd_notifications_dispatcher_send_seconds > 0: %v",metric.Histogram.GetSampleSum())`
`141`	`147`	`}`
`142`	`148`
	`149`	`+// this check is extremely flaky on windows. it fails more often than not, but not always`
	`150`	`+ifruntime.GOOS=="windows" {`
	`151`	`+returntrue`
	`152`	`+}`
	`153`	`+`
`143`	`154`	`// Dispatches should take a non-zero amount of time.`
`144`	`155`	`returnmetric.Histogram.GetSampleSum()>0`
`145`	`156`	`},`

Comments

(0)