Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit09f87d1

Browse files
authored
chore: remove empty case for metricscache (#6473)
This wasn't necessary to test and just caused flakes.See:https://github.com/coder/coder/actions/runs/4350034299/jobs/7600340648
1 parentcf75d7e commit09f87d1

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

‎coderd/metricscache/metricscache_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,10 +173,6 @@ func TestCache_TemplateUsers(t *testing.T) {
173173
Provisioner:database.ProvisionerTypeEcho,
174174
})
175175

176-
gotUniqueUsers,ok:=cache.TemplateUniqueUsers(template.ID)
177-
require.False(t,ok,"template shouldn't have loaded yet")
178-
require.EqualValues(t,-1,gotUniqueUsers)
179-
180176
for_,row:=rangett.args.rows {
181177
row.TemplateID=template.ID
182178
db.InsertWorkspaceAgentStat(context.Background(),row)
@@ -189,7 +185,7 @@ func TestCache_TemplateUsers(t *testing.T) {
189185
"TemplateDAUs never populated",
190186
)
191187

192-
gotUniqueUsers,ok=cache.TemplateUniqueUsers(template.ID)
188+
gotUniqueUsers,ok:=cache.TemplateUniqueUsers(template.ID)
193189
require.True(t,ok)
194190

195191
gotEntries,ok:=cache.TemplateDAUs(template.ID)

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp