Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit05c91c7

Browse files
committed
Fix: dbfake
1 parent6eb728f commit05c91c7

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

‎coderd/database/dbauthz/dbauthz.go

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1233,9 +1233,20 @@ func (q *querier) GetTemplateInsights(ctx context.Context, arg database.GetTempl
12331233
}
12341234

12351235
func (q*querier)GetTemplateParameterInsights(ctx context.Context,arg database.GetTemplateParameterInsightsParams) ([]database.GetTemplateParameterInsightsRow,error) {
1236-
// FIXME: this should maybe be READ rbac.ResourceTemplate or it's own resource.
1237-
iferr:=q.authorizeContext(ctx,rbac.ActionRead,rbac.ResourceSystem);err!=nil {
1238-
returnnil,err
1236+
for_,templateID:=rangearg.TemplateIDs {
1237+
template,err:=q.db.GetTemplateByID(ctx,templateID)
1238+
iferr!=nil {
1239+
returnnil,err
1240+
}
1241+
1242+
iferr:=q.authorizeContext(ctx,rbac.ActionUpdate,template);err!=nil {
1243+
returnnil,err
1244+
}
1245+
}
1246+
iflen(arg.TemplateIDs)==0 {
1247+
iferr:=q.authorizeContext(ctx,rbac.ActionUpdate,rbac.ResourceTemplate.All());err!=nil {
1248+
returnnil,err
1249+
}
12391250
}
12401251
returnq.db.GetTemplateParameterInsights(ctx,arg)
12411252
}

‎coderd/database/dbfake/dbfake.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2147,7 +2147,7 @@ func (q *FakeQuerier) GetTemplateParameterInsights(ctx context.Context, arg data
21472147
deferq.mutex.RUnlock()
21482148

21492149
// WITH latest_workspace_builds ...
2150-
latestWorkspaceBuilds:=make(map[uuid.UUID]database.WorkspaceBuild)
2150+
latestWorkspaceBuilds:=make(map[uuid.UUID]database.WorkspaceBuildTable)
21512151
for_,wb:=rangeq.workspaceBuilds {
21522152
ifwb.CreatedAt.Before(arg.StartTime)||wb.CreatedAt.Equal(arg.EndTime)||wb.CreatedAt.After(arg.EndTime) {
21532153
continue

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp