NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

Commit04dfda8

authored

fix: change enqueue error to debug log level (#19686)

fixescoder/internal#958Logging was being done at error level, but most likely any errors are from simple races between an update triggered around the same time as a client disconnecting. Debug is fine for these.

1 parentd415964 commit04dfda8Copy full SHA for 04dfda8

File tree

1 file changed

-2

lines changed

enterprise/tailnet
- pgcoord.go

1 file changed

-2

lines changed

`‎enterprise/tailnet/pgcoord.go‎`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -693,8 +693,9 @@ func (m *mapper) run() {`
`693`	`693`	`m.logger.Debug(m.ctx,"skipping nil node update")`
`694`	`694`	`continue`
`695`	`695`	`}`
`696`		`-iferr:=m.c.Enqueue(update);err!=nil&&!xerrors.Is(err,context.Canceled) {`
`697`		`-m.logger.Error(m.ctx,"failed to enqueue node update",slog.Error(err))`
	`696`	`+iferr:=m.c.Enqueue(update);err!=nil {`
	`697`	`+// lots of reasons this could happen, most usually, the peer has disconnected.`
	`698`	`+m.logger.Debug(m.ctx,"failed to enqueue node update",slog.Error(err))`
`698`	`699`	`}`
`699`	`700`	`}`
`700`	`701`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit04dfda8

File tree

1 file changed

1 file changed

`‎enterprise/tailnet/pgcoord.go‎`

0 commit comments