NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

Commit04c3396

authored

refactor: replacegolang.org/x/exp/slices withslices (#16772)

The experimental functions in `golang.org/x/exp/slices` are nowavailable in the standard library since Go 1.21.Reference:https://go.dev/doc/go1.21#slicesSigned-off-by: Eng Zer Jun <engzerjun@gmail.com>

1 parent88f0131 commit04c3396Copy full SHA for 04c3396

File tree

52 files changed

+53

-55

lines changed

agent
- agent.go
- agent_test.go
- agentssh
  - agentssh.go
- agenttest
  - client.go
- reconnectingpty
  - buffered.go
cli
coderd
- agentapi
  - lifecycle.go
- audit
  - audit.go
- database
  - db2sdk
    - db2sdk.go
  - dbauthz
    - dbauthz.go
  - dbmem
    - dbmem.go
  - dbmetrics
    - dbmetrics.go
    - querymetrics.go
  - dbpurge
    - dbpurge_test.go
  - gentest
    - modelqueries_test.go
  - migrations
    - migrate_test.go
- debug.go
- devtunnel
  - servers.go
- entitlements
  - entitlements.go
- healthcheck
  - database.go
  - derphealth
    - derp.go
- httpmw
  - apikey_test.go
- idpsync
- insights.go
- notifications_test.go
- prometheusmetrics/insights
  - metricscollector.go
- provisionerdserver
- userpassword
  - userpassword.go
- users_test.go
- workspaceagents.go
- workspaceapps
  - db.go
  - stats_test.go
- workspacebuilds.go
- workspacebuilds_test.go
codersdk
- agentsdk
  - logs_internal_test.go
  - logs_test.go
- healthsdk
  - interfaces_internal_test.go
- provisionerdaemons.go
enterprise/coderd/license
- license_test.go
pty/ptytest
- ptytest.go
scaletest/workspacetraffic
- run_test.go
site
- site.go
tailnet
- node.go
- node_internal_test.go

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+53

-55

lines changed

`‎agent/agent.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ import (`
`14`	`14`	`"os"`
`15`	`15`	`"os/user"`
`16`	`16`	`"path/filepath"`
	`17`	`+"slices"`
`17`	`18`	`"sort"`
`18`	`19`	`"strconv"`
`19`	`20`	`"strings"`
`@@ -26,7 +27,6 @@ import (`
`26`	`27`	`"github.com/prometheus/common/expfmt"`
`27`	`28`	`"github.com/spf13/afero"`
`28`	`29`	`"go.uber.org/atomic"`
`29`		`-"golang.org/x/exp/slices"`
`30`	`30`	`"golang.org/x/sync/errgroup"`
`31`	`31`	`"golang.org/x/xerrors"`
`32`	`32`	`"google.golang.org/protobuf/types/known/timestamppb"`

`‎agent/agent_test.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ import (`
`19`	`19`	`"path/filepath"`
`20`	`20`	`"regexp"`
`21`	`21`	`"runtime"`
	`22`	`+"slices"`
`22`	`23`	`"strconv"`
`23`	`24`	`"strings"`
`24`	`25`	`"sync/atomic"`
`@@ -41,7 +42,6 @@ import (`
`41`	`42`	`"github.com/stretchr/testify/assert"`
`42`	`43`	`"github.com/stretchr/testify/require"`
`43`	`44`	`"golang.org/x/crypto/ssh"`
`44`		`-"golang.org/x/exp/slices"`
`45`	`45`	`"golang.org/x/xerrors"`
`46`	`46`
`47`	`47`	`"cdr.dev/slog"`

`‎agent/agentssh/agentssh.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ import (`
`12`	`12`	`"os/user"`
`13`	`13`	`"path/filepath"`
`14`	`14`	`"runtime"`
	`15`	`+"slices"`
`15`	`16`	`"strings"`
`16`	`17`	`"sync"`
`17`	`18`	`"time"`
`@@ -24,7 +25,6 @@ import (`
`24`	`25`	`"github.com/spf13/afero"`
`25`	`26`	`"go.uber.org/atomic"`
`26`	`27`	`gossh"golang.org/x/crypto/ssh"`
`27`		`-"golang.org/x/exp/slices"`
`28`	`28`	`"golang.org/x/xerrors"`
`29`	`29`
`30`	`30`	`"cdr.dev/slog"`

`‎agent/agenttest/client.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ package agenttest`
`3`	`3`	`import (`
`4`	`4`	`"context"`
`5`	`5`	`"io"`
	`6`	`+"slices"`
`6`	`7`	`"sync"`
`7`	`8`	`"sync/atomic"`
`8`	`9`	`"testing"`
`@@ -12,7 +13,6 @@ import (`
`12`	`13`	`"github.com/stretchr/testify/assert"`
`13`	`14`	`"github.com/stretchr/testify/require"`
`14`	`15`	`"golang.org/x/exp/maps"`
`15`		`-"golang.org/x/exp/slices"`
`16`	`16`	`"golang.org/x/xerrors"`
`17`	`17`	`"google.golang.org/protobuf/types/known/durationpb"`
`18`	`18`	`"google.golang.org/protobuf/types/known/emptypb"`

`‎agent/reconnectingpty/buffered.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,11 +5,11 @@ import (`
`5`	`5`	`"errors"`
`6`	`6`	`"io"`
`7`	`7`	`"net"`
	`8`	`+"slices"`
`8`	`9`	`"time"`
`9`	`10`
`10`	`11`	`"github.com/armon/circbuf"`
`11`	`12`	`"github.com/prometheus/client_golang/prometheus"`
`12`		`-"golang.org/x/exp/slices"`
`13`	`13`	`"golang.org/x/xerrors"`
`14`	`14`
`15`	`15`	`"cdr.dev/slog"`

`‎cli/configssh.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ import (`
`11`	`11`	`"os"`
`12`	`12`	`"path/filepath"`
`13`	`13`	`"runtime"`
	`14`	`+"slices"`
`14`	`15`	`"strconv"`
`15`	`16`	`"strings"`
`16`	`17`
`@@ -19,7 +20,6 @@ import (`
`19`	`20`	`"github.com/pkg/diff"`
`20`	`21`	`"github.com/pkg/diff/write"`
`21`	`22`	`"golang.org/x/exp/constraints"`
`22`		`-"golang.org/x/exp/slices"`
`23`	`23`	`"golang.org/x/xerrors"`
`24`	`24`
`25`	`25`	`"github.com/coder/coder/v2/cli/cliui"`

`‎cli/create.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4,11 +4,11 @@ import (`
`4`	`4`	`"context"`
`5`	`5`	`"fmt"`
`6`	`6`	`"io"`
	`7`	`+"slices"`
`7`	`8`	`"strings"`
`8`	`9`	`"time"`
`9`	`10`
`10`	`11`	`"github.com/google/uuid"`
`11`		`-"golang.org/x/exp/slices"`
`12`	`12`	`"golang.org/x/xerrors"`
`13`	`13`
`14`	`14`	`"github.com/coder/pretty"`

`‎cli/exp_scaletest.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ import (`
`12`	`12`	`"net/url"`
`13`	`13`	`"os"`
`14`	`14`	`"os/signal"`
	`15`	`+"slices"`
`15`	`16`	`"strconv"`
`16`	`17`	`"strings"`
`17`	`18`	`"sync"`
`@@ -21,7 +22,6 @@ import (`
`21`	`22`	`"github.com/prometheus/client_golang/prometheus"`
`22`	`23`	`"github.com/prometheus/client_golang/prometheus/promhttp"`
`23`	`24`	`"go.opentelemetry.io/otel/trace"`
`24`		`-"golang.org/x/exp/slices"`
`25`	`25`	`"golang.org/x/xerrors"`
`26`	`26`
`27`	`27`	`"cdr.dev/slog"`

`‎cli/root.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ import (`
`17`	`17`	`"path/filepath"`
`18`	`18`	`"runtime"`
`19`	`19`	`"runtime/trace"`
	`20`	`+"slices"`
`20`	`21`	`"strings"`
`21`	`22`	`"sync"`
`22`	`23`	`"syscall"`
`@@ -25,7 +26,6 @@ import (`
`25`	`26`
`26`	`27`	`"github.com/mattn/go-isatty"`
`27`	`28`	`"github.com/mitchellh/go-wordwrap"`
`28`		`-"golang.org/x/exp/slices"`
`29`	`29`	`"golang.org/x/mod/semver"`
`30`	`30`	`"golang.org/x/xerrors"`
`31`	`31`

`‎cli/tokens.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,10 +3,10 @@ package cli`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
`5`	`5`	`"os"`
	`6`	`+"slices"`
`6`	`7`	`"strings"`
`7`	`8`	`"time"`
`8`	`9`
`9`		`-"golang.org/x/exp/slices"`
`10`	`10`	`"golang.org/x/xerrors"`
`11`	`11`
`12`	`12`	`"github.com/coder/coder/v2/cli/cliui"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit04c3396

File tree

52 files changed

Some content is hidden

52 files changed

`‎agent/agent.go‎`

`‎agent/agent_test.go‎`

`‎agent/agentssh/agentssh.go‎`

`‎agent/agenttest/client.go‎`

`‎agent/reconnectingpty/buffered.go‎`

`‎cli/configssh.go‎`

`‎cli/create.go‎`

`‎cli/exp_scaletest.go‎`

`‎cli/root.go‎`

`‎cli/tokens.go‎`

0 commit comments