NotificationsYou must be signed in to change notification settings
Fork1k
Star11.1k

Commit039fa89

authored

fix(coderd): correct the name of the unmarshall error variable (#20150)

Incorrect error variable is used during reporting of the issue duringunmarshall operations and this makes it hard to understand theunderlying reason for OIDC failure: use `unmarshalError` instead of`err`.

1 parentffcb7a1 commit039fa89Copy full SHA for 039fa89

File tree

1 file changed

-1

lines changed

coderd/oauthpki
- oidcpki.go

1 file changed

-1

lines changed

`‎coderd/oauthpki/oidcpki.go‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ func (src jwtTokenSource) Token() (oauth2.Token, error) {`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`ifunmarshalError!=nil {`
`250`		`-returnnil,xerrors.Errorf("oauth2: cannot unmarshal token: %w",err)`
	`250`	`+returnnil,xerrors.Errorf("oauth2: cannot unmarshal token: %w",unmarshalError)`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`newToken:=&oauth2.Token{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit039fa89

File tree

1 file changed

1 file changed

`‎coderd/oauthpki/oidcpki.go‎`

0 commit comments