Commit02b2de9

authored

refactor: skip reconciliation for some presets (#17595)

1 parent268a50c commit02b2de9Copy full SHA for 02b2de9

File tree

+13

-0

lines changed

+13

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,10 @@ type ReconciliationActions struct {`
`72`	`72`	`BackoffUntil time.Time`
`73`	`73`	`}`
`74`	`74`
	`75`	`+func (ra*ReconciliationActions)IsNoop()bool {`
	`76`	`+returnra.Create==0&&len(ra.DeleteIDs)==0&&ra.BackoffUntil.IsZero()`
	`77`	`+}`
	`78`	`+`
`75`	`79`	`// CalculateState computes the current state of prebuilds for a preset, including:`
`76`	`80`	`// - Actual: Number of currently running prebuilds`
`77`	`81`	`// - Desired: Number of prebuilds desired as defined in the preset`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -310,6 +310,15 @@ func (c *StoreReconciler) ReconcilePreset(ctx context.Context, ps prebuilds.Pres`
`310`	`310`	`returnnil`
`311`	`311`	`}`
`312`	`312`
	`313`	`+// Nothing has to be done.`
	`314`	`+if!ps.Preset.UsingActiveVersion&&actions.IsNoop() {`
	`315`	`+logger.Debug(ctx,"skipping reconciliation for preset - nothing has to be done",`
	`316`	`+slog.F("template_id",ps.Preset.TemplateID.String()),slog.F("template_name",ps.Preset.TemplateName),`
	`317`	`+slog.F("template_version_id",ps.Preset.TemplateVersionID.String()),slog.F("template_version_name",ps.Preset.TemplateVersionName),`
	`318`	`+slog.F("preset_id",ps.Preset.ID.String()),slog.F("preset_name",ps.Preset.Name))`
	`319`	`+returnnil`
	`320`	`+}`
	`321`	`+`
`313`	`322`	`// nolint:gocritic // ReconcilePreset needs Prebuilds Orchestrator permissions.`
`314`	`323`	`prebuildsCtx:=dbauthz.AsPrebuildsOrchestrator(ctx)`
`315`	`324`

Comments

(0)