Commit018e920

committed

fix(coderd): use TruncateOptions in enqueueAITaskStateNotification and update tests

1 parentd7b42a8 commit018e920Copy full SHA for 018e920

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import (`
`9`	`9`	`"strings"`
`10`	`10`	`"testing"`
`11`	`11`	`"time"`
	`12`	`+"unicode/utf8"`
`12`	`13`
`13`	`14`	`"github.com/google/uuid"`
`14`	`15`	`"github.com/stretchr/testify/assert"`
`@@ -1133,9 +1134,10 @@ func TestTasksNotification(t *testing.T) {`
`1133`	`1134`	`require.Len(t,sent,1)`
`1134`	`1135`	`require.Equal(t,memberUser.ID,sent[0].UserID)`
`1135`	`1136`	`require.Len(t,sent[0].Labels,2)`
`1136`		`-require.LessOrEqual(t,len(sent[0].Labels["task"]),160)`
	`1137`	`+// NOTE: len(string) is the number of bytes in the string, not the number of runes.`
	`1138`	`+require.LessOrEqual(t,utf8.RuneCountInString(sent[0].Labels["task"]),160)`
`1137`	`1139`	`iflen(tc.taskPrompt)>160 {`
`1138`		`-require.Contains(t,tc.taskPrompt,strings.TrimSuffix(sent[0].Labels["task"],"..."))`
	`1140`	`+require.Contains(t,tc.taskPrompt,strings.TrimSuffix(sent[0].Labels["task"],"…"))`
`1139`	`1141`	`}else {`
`1140`	`1142`	`require.Equal(t,tc.taskPrompt,sent[0].Labels["task"])`
`1141`	`1143`	`}`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -486,8 +486,7 @@ func (api *API) enqueueAITaskStateNotification(`
`486`	`486`
`487`	`487`	`// As task prompt may be particularly long, truncate it to 160 characters for notifications.`
`488`	`488`	`iflen(taskName)>160 {`
`489`		`-taskName=taskName[:157]`
`490`		`-taskName+="..."`
	`489`	`+taskName=strutil.Truncate(taskName,160,strutil.TruncateWithEllipsis,strutil.TruncateWithFullWords)`
`491`	`490`	`}`
`492`	`491`
`493`	`492`	`if_,err:=api.NotificationsEnqueuer.EnqueueWithData(`

Comments

(0)