- Notifications
You must be signed in to change notification settings - Fork0
Fix goroutine leaks in CONNECT connection handling#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
blink-so wants to merge2 commits intomainChoose a base branch fromblink/fix-goroutine-leaks-connect
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+70 −20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This fixes three goroutine leaks that were causing CPU and memory usage tobuild up over time:1. streamRequestToTarget: Orphaned bidirectional copy goroutines that never terminated properly when connections closed early2. handleConnectStreaming: Similar issue with bidirectional tunnel goroutines that could hang indefinitelyChanges made:- Use errgroup to properly manage and synchronize goroutine lifecycle- Add connection deadlines (5 min) to prevent indefinite blocking on io.Copy- Close write side of connections after copy completes to signal EOF- Add context cancellation monitoring to force cleanup if needed- Improved error handling to ignore expected EOF/ErrClosed errorsCo-authored-by: f0ssel <19379394+f0ssel@users.noreply.github.com>
Connections need to stay open indefinitely for valid use cases.The errgroup synchronization alone is sufficient to prevent goroutine leaks.Co-authored-by: f0ssel <19379394+f0ssel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
The proxy was building up CPU and memory usage over time due to goroutine leaks in CONNECT connection handling. Three specific leaks were identified:
Solution
The errgroup ensures that:
Testing
✅ All existing tests pass
✅ Code compiles without errors
Changes
golang.org/x/sync/errgroup
dependencystreamRequestToTarget
to use errgroup with 3 goroutines (request copy, response copy, cleanup monitor)handleConnectStreaming
to use errgroup with 3 goroutines (client→target, target→client, cleanup monitor)