- Notifications
You must be signed in to change notification settings - Fork96
feat(termexec): handle agent animations#145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
✅ Preview binaries are ready! To test with modules: |
35C4n0r commentedNov 18, 2025
formatting for the amp is ready and will be pushed in the next PR. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
lib/termexec/utils.go Outdated
| } | ||
| } | ||
| } | ||
| return animatedContentEnd, continueRemoving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you add some tests for this?
| if len(lines) >= 2 { | ||
| return 2, true | ||
| } | ||
| return -1, true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This code is largely the same, but the continue removing variable seems new, perhaps we should ensure we've covered the new behavior with tests?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
feat(termexec): enhance dynamic header (animation) handling for different agent types