Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[UI][RFC] SelectiveView#471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
senwang86 wants to merge1 commit intocodepod-io:main
base:main
Choose a base branch
Loading
fromsenwang86:selective_view

Conversation

senwang86
Copy link
Collaborator

@senwang86senwang86 commentedAug 26, 2023•
edited
Loading

Summary

A prototype ofSelectiveView via multi-select items inToC

  • The Canvas only displays selected pods.
  • TheEdit mode is not affected.

However

  • The current implementation renders a deep copy of theselected pods fromnodesMap inupdateView(), thus ALL operations that engage withnodesMap need to be properly synced, e.g., moving a pod, creating a new pod, changing the size of a pod, etc. I am not exactly sure if it's the best approach and ask for some comments here.

Test

selective_view

@senwang86senwang86 requested a review fromlihebiAugust 26, 2023 02:14
@lihebi
Copy link
Collaborator

  • The current implementation renders a deep copy of theselected pods fromnodesMap inupdateView()

I didn't see "a deep copy". I think you are doing the right thing here, to compute a subset of nodes andset({nodes}).

However, I don't quite understand the gif/code:

  1. Your gif doesn't show a "partial view" of the canvas. All pods seem to be shown.
  2. The sidebar ToC should be "togglable" into three states (selected, hidden, blocked), something like this:

image

@senwang86
Copy link
CollaboratorAuthor

  1. Your gif doesn't show a "partial view" of the canvas. All pods seem to be shown.

It's due to the native multi-selection of tree-view, instead ofcheckbox-based selection, theselective view happens when there're more than 1 items selected in ToC.

@lihebi
Copy link
Collaborator

theselective view happens when there're more than 1 items selected in ToC.

Oh, I see.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lihebilihebiAwaiting requested review from lihebi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@senwang86@lihebi
[8]ページ先頭
©2009-2025 Movatter.jp