Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

For Windows OS, revert the usage of cmd.exe by default#42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
axel3rd wants to merge1 commit intocodehaus-plexus:masterfromaxel3rd:RevertCmdUsageByDefaultOnWindows
Closed

For Windows OS, revert the usage of cmd.exe by default#42

axel3rd wants to merge1 commit intocodehaus-plexus:masterfromaxel3rd:RevertCmdUsageByDefaultOnWindows

Conversation

@axel3rd
Copy link
Contributor

cf.#17 (comments from May 2018): Revert the usage ofcmd.exe by default (on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.

Allow this behavior by the usage of a new method:

Commandline cmd = new Commandline();cmd.setForceShellOsSpefic( true );

This PR should be chosen or#41.

@michael-o
Copy link
Member

Very good, I'd even go so far and drop the same stuff for Unix. Never understood why one has to invoke/bin/sh at all.

@axel3rd
Copy link
ContributorAuthor

I'd even go so far and drop the same stuff for Unix

Why not, but out of scope of this pull request IMO, designed to fix theCTRL+C problem on Windows.

@michael-o
Copy link
Member

Correct.

@mkarg
Copy link
Collaborator

@axel3rd Please fix the conflicts. Thanks.

@axel3rd
Copy link
ContributorAuthor

@axel3rd Please fix the conflicts. Thanks.

@mkarg : Sorry, not able todo that in this PR, because is >2 years old so I have deleted the fork since this time.

@axel3rd
Copy link
ContributorAuthor

See#41, usage of a shell wrapper is not really a relevant behavior => closing

@axel3rd
Copy link
ContributorAuthor

See#110 for following.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axel3rd@michael-o@mkarg
[8]ページ先頭
©2009-2025 Movatter.jp