Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Revert usage of cmd on Windows#41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
axel3rd wants to merge1 commit intocodehaus-plexus:masterfromaxel3rd:RevertCmdUsageOnWindows
Closed

Revert usage of cmd on Windows#41

axel3rd wants to merge1 commit intocodehaus-plexus:masterfromaxel3rd:RevertCmdUsageOnWindows

Conversation

@axel3rd
Copy link
Contributor

cf.#17 (comments from May 2018): Revert the usage ofcmd.exe (on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.

For history: This Windows shell specific is removed sinceplexus-utils 3.0.15, except for 3.1.0.

On Windows, the usage ofcmd builtin (likeecho) or.cmd /.bat onPATH should be implemented by the client.

@axel3rd
Copy link
ContributorAuthor

Travisoraclejdk7 support seems removed (seehere).
Could be done in // PR if not relevant here.

@michael-o
Copy link
Member

Please move the OpenJDK 7 commit to a separate PR.

@axel3rd
Copy link
ContributorAuthor

About openjdk7: already inissue-fix branch (commit:54f6ca0d9c7d0940f84610788f3e55c2548dc5c4).

@axel3rd
Copy link
ContributorAuthor

Other PR#42, to propose an approach forcmd usage if wanted (consensus ? hardcode acmd.exe /X /C for a simpleecho disturb me 😜).

@mkarg
Copy link
Collaborator

@axel3rd Please fix conflicts. Thanks.

@axel3rd
Copy link
ContributorAuthor

@axel3rd Please fix the conflicts. Thanks.

@mkarg : Sorry, not able todo that in this PR, because is >2 years old so I have deleted the fork since this time.

@michael-o
Copy link
Member

@axel3rd Please fix the conflicts. Thanks.

@mkarg : Sorry, not able todo that in this PR, because is >2 years old so I have deleted the fork since this time.

That's ok.@mkarg Honestly, I don't see a reason to have a shell wrapper at all, but useProcessBuilder. This worked for me for years. Those wrappers only cause confusion and issues which I have to fix in Maven SCM.

@mkarg
Copy link
Collaborator

@axel3rd Please fix the conflicts. Thanks.
@mkarg : Sorry, not able todo that in this PR, because is >2 years old so I have deleted the fork since this time.
That's ok.@mkarg Honestly, I don't see a reason to have a shell wrapper at all, but useProcessBuilder. This worked for me for years. Those wrappers only cause confusion and issues which I have to fix in Maven SCM.

My target is to cleaup the open PRs, so either we merge or drop them or turn them intodrafts, but not keep them open for
review for more years in an unclear state. To reach that goal, first the original authors need to resolve conflicts to allow reviews ontop master. I am looking into theactual change once the code at least will compile again.

michael-o reacted with thumbs up emojimichael-o reacted with heart emoji

@axel3rd
Copy link
ContributorAuthor

My target is to cleaup the open PRs, [...] not keep them open for review for more years in an unclear state

Fully agree with that 👍

I don't see a reason to have a shell wrapper at all, but use ProcessBuilder

I understand the content of this PR is not really relevant, so closing.

@michael-o
Copy link
Member

My target is to cleaup the open PRs, [...] not keep them open for review for more years in an unclear state

Fully agree with that 👍

I don't see a reason to have a shell wrapper at all, but use ProcessBuilder

I understand the content of this PR is not really relevant, so closing.

I didn't say that. What I am saying is that our concept is wrong from begin with.

@axel3rd
Copy link
ContributorAuthor

I didn't say that. What I am saying is that our concept is wrong from begin with.

Ok, sorry, misunderstanding from my side.

I will provide some new compiling PR for#41 &#42 and not delete the fork until status, allowing review.

@michael-o
Copy link
Member

I didn't say that. What I am saying is that our concept is wrong from begin with.

Ok, sorry, misunderstanding from my side.

I will provide some new compiling PR for#41 &#42 and not delete the fork until status, allowing review.

Thanks! Take your time! No need to hurry.

@axel3rd
Copy link
ContributorAuthor

See#109 for following.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axel3rd@michael-o@mkarg

[8]ページ先頭

©2009-2025 Movatter.jp