Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use Path in the Scanner API#226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
laeubi wants to merge1 commit intocodehaus-plexus:master
base:master
Choose a base branch
Loading
fromlaeubi:move_scanner_to_path_minimal

Conversation

@laeubi
Copy link

This would be a minimal change to move the API ofScanner to thePath API

This could be some kind of minimal change that could be merged as base for larger changes like:

@laeubi
Copy link
Author

@olamy could this be a first step?

@kwin
Copy link
Contributor

kwin commentedJan 5, 2023

Also look atapache/maven-shared-utils#54. IMHO we should only implement in one library....

@laeubi
Copy link
Author

Also look atapache/maven-shared-utils#54. IMHO we should only implement in one library....

The most notable thing I see is that it is two years old now and no progress at all...

@gnodet
Copy link
Member

I'm a bit skeptical about breaking the API and replacing the return type of thegetBasedir().
A less problematic approach would be to provide a different method which would return aPath instead, or a new interface if we want to avoid having bothFile andPath in the same interface (the implementation could implement both interface, provided they use different names for the conflicting methods).

@slachiewiczslachiewicz marked this pull request as draftJanuary 5, 2025 10:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laeubi@kwin@gnodet

[8]ページ先頭

©2009-2025 Movatter.jp