- Notifications
You must be signed in to change notification settings - Fork24
Add inline cron triggers tocodefresh_pipeline#122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codefresh_pipeline/test |
/test |
korenyoni approved these changesAug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, had to fix tests and create deprecations forpipeline_cron_trigger.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What
[codefresh_pipeline]: addspec.cron_triggerWhy
New feature that supersedespipeline_cron_trigger added in#90 (the API used by
pipeline_cron_triggeris limited; additional cron trigger options were recently added to the pipelines API, currently behind a feature flag)Notes
Will be first released as part of
0.6.0-beta-1(pre-release)Checklist
/testcomment will be ignored by the CI triggerunless it is made by a repo admin or collaborator.