- Notifications
You must be signed in to change notification settings - Fork165
feat(ui): added helpbub#970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cf-ci-bot commentedApr 18, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
cf-ci-bot commentedApr 18, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
cf-ci-bot commentedMay 1, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
cf-ci-bot commentedMay 1, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
cf-ci-bot commentedMay 2, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
cf-ci-bot commentedMay 9, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
cf-ci-bot commentedMay 9, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
| {% if page.layout != "home" %} | ||
| <button | ||
| onclick="window.CommandBar.toggleHelpHub()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we also add accessibility attributes to this button?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sure, you mean aria-labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
but it has text inside of it btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just to make sure it's accessibe via keyboard and a screen reader
_includes/scripts.html Outdated
| }, | ||
| varo="3033bf7f",n=["Object.assign","Symbol","Symbol.for"].join("%2C"),a=window;functiont(o,n){void0===n&&(n=!1),"complete"!==document.readyState&&window.addEventListener("load",t.bind(null,o,n),{capture:!1,once:!0});vara=document.createElement("script");a.type="text/javascript",a.async=n,a.src=o,document.head.appendChild(a)}functionr(){varn;if(void0===a.CommandBar){deletea.__CommandBarBootstrap__;varr=Symbol.for("CommandBar::configuration"),e=Symbol.for("CommandBar::orgConfig"),c=Symbol.for("CommandBar::disposed"),i=Symbol.for("CommandBar::isProxy"),m=Symbol.for("CommandBar::queue"),l=Symbol.for("CommandBar::unwrap"),d=[],s=localStorage.getItem("commandbar.lc"),u=s&&s.includes("local")?"http://localhost:8000":"https://api.commandbar.com",f=Object.assign(((n={})[r]={uuid:o},n[e]={},n[c]=!1,n[i]=!0,n[m]=newArray,n[l]=function(){returnf},n),a.CommandBar),p=["addCommand","boot"],y=f;Object.assign(f,{shareCallbacks:function(){return{}},shareContext:function(){return{}}}),a.CommandBar=newProxy(f,{get:function(o,n){returnniny?f[n]:p.includes(n)?function(){varo=Array.prototype.slice.call(arguments);returnnewPromise((function(a,t){o.unshift(n,a,t),f[m].push(o)}))}:function(){varo=Array.prototype.slice.call(arguments);o.unshift(n),f[m].push(o)}}}),null!==s&&d.push("lc=".concat(s)),d.push("version=2"),t("".concat(u,"/latest/").concat(o,"?").concat(d.join("&")),!0)}}void0===Object.assign||"undefined"==typeofSymbol||void0===Symbol.for?(a.__CommandBarBootstrap__=r,t("https://polyfill.io/v3/polyfill.min.js?version=3.101.0&callback=__CommandBarBootstrap__&features="+n)):r(); | ||
| window.CommandBar.boot( | ||
| "docs-test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Need to check the API add see if we need to rename thedocs-test (I think it's a field for a user name)
olegt-codefreshMay 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
_includes/scripts.html Outdated
| }], | ||
| apiKey:'5aRIuEbEpw9LTf2B5te4Essx4o4HE4Fl',// Use API Key with only Search permissions | ||
| }, | ||
| varo="3033bf7f",n=["Object.assign","Symbol","Symbol.for"].join("%2C"),a=window;functiont(o,n){void0===n&&(n=!1),"complete"!==document.readyState&&window.addEventListener("load",t.bind(null,o,n),{capture:!1,once:!0});vara=document.createElement("script");a.type="text/javascript",a.async=n,a.src=o,document.head.appendChild(a)}functionr(){varn;if(void0===a.CommandBar){deletea.__CommandBarBootstrap__;varr=Symbol.for("CommandBar::configuration"),e=Symbol.for("CommandBar::orgConfig"),c=Symbol.for("CommandBar::disposed"),i=Symbol.for("CommandBar::isProxy"),m=Symbol.for("CommandBar::queue"),l=Symbol.for("CommandBar::unwrap"),d=[],s=localStorage.getItem("commandbar.lc"),u=s&&s.includes("local")?"http://localhost:8000":"https://api.commandbar.com",f=Object.assign(((n={})[r]={uuid:o},n[e]={},n[c]=!1,n[i]=!0,n[m]=newArray,n[l]=function(){returnf},n),a.CommandBar),p=["addCommand","boot"],y=f;Object.assign(f,{shareCallbacks:function(){return{}},shareContext:function(){return{}}}),a.CommandBar=newProxy(f,{get:function(o,n){returnniny?f[n]:p.includes(n)?function(){varo=Array.prototype.slice.call(arguments);returnnewPromise((function(a,t){o.unshift(n,a,t),f[m].push(o)}))}:function(){varo=Array.prototype.slice.call(arguments);o.unshift(n),f[m].push(o)}}}),null!==s&&d.push("lc=".concat(s)),d.push("version=2"),t("".concat(u,"/latest/").concat(o,"?").concat(d.join("&")),!0)}}void0===Object.assign||"undefined"==typeofSymbol||void0===Symbol.for?(a.__CommandBarBootstrap__=r,t("https://polyfill.io/v3/polyfill.min.js?version=3.101.0&callback=__CommandBarBootstrap__&features="+n)):r(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please make sure it's the latest code snippet from the commandbar docs:
https://www.commandbar.com/docs/guides/installation/installation-types/installing-in-web-app/#option-2-snippet
| </p> | ||
| <divid="searchbar"></div> | ||
| <!-- <div id="searchbar"></div>--> | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
accessibility attributes for the button
yarn.lock Outdated
| output-file-sync "^2.0.0" | ||
| slash "^1.0.0" | ||
| source-map "^0.5.0" | ||
| "@ampproject/remapping@^2.2.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is this change caused byyarn upgrade or we have uncommitted changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i ran 'yarn' command, anyway, i'll clear changes from here
…me; refreshed helpbub code snippet
cf-ci-bot commentedMay 9, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
1 similar comment
cf-ci-bot commentedMay 9, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |
cf-ci-bot commentedMay 10, 2024
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-22957/docs/ |

No description provided.