Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(ui): added helpbub#970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
NimRegev merged 11 commits intomasterfromCR-22957
May 27, 2024
Merged

feat(ui): added helpbub#970

NimRegev merged 11 commits intomasterfromCR-22957
May 27, 2024

Conversation

@alinashklyar
Copy link
Contributor

No description provided.

@cf-ci-bot
Copy link

@cf-ci-bot
Copy link

@cf-ci-bot
Copy link

@cf-ci-bot
Copy link

@cf-ci-bot
Copy link

@cf-ci-bot
Copy link

@cf-ci-bot
Copy link


{% if page.layout != "home" %}
<button
onclick="window.CommandBar.toggleHelpHub()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we also add accessibility attributes to this button?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

sure, you mean aria-labels?

olegt-codefresh reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

but it has text inside of it btw

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just to make sure it's accessibe via keyboard and a screen reader

},
varo="3033bf7f",n=["Object.assign","Symbol","Symbol.for"].join("%2C"),a=window;functiont(o,n){void0===n&&(n=!1),"complete"!==document.readyState&&window.addEventListener("load",t.bind(null,o,n),{capture:!1,once:!0});vara=document.createElement("script");a.type="text/javascript",a.async=n,a.src=o,document.head.appendChild(a)}functionr(){varn;if(void0===a.CommandBar){deletea.__CommandBarBootstrap__;varr=Symbol.for("CommandBar::configuration"),e=Symbol.for("CommandBar::orgConfig"),c=Symbol.for("CommandBar::disposed"),i=Symbol.for("CommandBar::isProxy"),m=Symbol.for("CommandBar::queue"),l=Symbol.for("CommandBar::unwrap"),d=[],s=localStorage.getItem("commandbar.lc"),u=s&&s.includes("local")?"http://localhost:8000":"https://api.commandbar.com",f=Object.assign(((n={})[r]={uuid:o},n[e]={},n[c]=!1,n[i]=!0,n[m]=newArray,n[l]=function(){returnf},n),a.CommandBar),p=["addCommand","boot"],y=f;Object.assign(f,{shareCallbacks:function(){return{}},shareContext:function(){return{}}}),a.CommandBar=newProxy(f,{get:function(o,n){returnniny?f[n]:p.includes(n)?function(){varo=Array.prototype.slice.call(arguments);returnnewPromise((function(a,t){o.unshift(n,a,t),f[m].push(o)}))}:function(){varo=Array.prototype.slice.call(arguments);o.unshift(n),f[m].push(o)}}}),null!==s&&d.push("lc=".concat(s)),d.push("version=2"),t("".concat(u,"/latest/").concat(o,"?").concat(d.join("&")),!0)}}void0===Object.assign||"undefined"==typeofSymbol||void0===Symbol.for?(a.__CommandBarBootstrap__=r,t("https://polyfill.io/v3/polyfill.min.js?version=3.101.0&callback=__CommandBarBootstrap__&features="+n)):r();
window.CommandBar.boot(
"docs-test",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Need to check the API add see if we need to rename thedocs-test (I think it's a field for a user name)

Copy link
Contributor

@olegt-codefresholegt-codefreshMay 9, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's check with Idan if we should add fixedid like"documentation-user" or pass an empty string as for anonymous user.

image

}],
apiKey:'5aRIuEbEpw9LTf2B5te4Essx4o4HE4Fl',// Use API Key with only Search permissions
},
varo="3033bf7f",n=["Object.assign","Symbol","Symbol.for"].join("%2C"),a=window;functiont(o,n){void0===n&&(n=!1),"complete"!==document.readyState&&window.addEventListener("load",t.bind(null,o,n),{capture:!1,once:!0});vara=document.createElement("script");a.type="text/javascript",a.async=n,a.src=o,document.head.appendChild(a)}functionr(){varn;if(void0===a.CommandBar){deletea.__CommandBarBootstrap__;varr=Symbol.for("CommandBar::configuration"),e=Symbol.for("CommandBar::orgConfig"),c=Symbol.for("CommandBar::disposed"),i=Symbol.for("CommandBar::isProxy"),m=Symbol.for("CommandBar::queue"),l=Symbol.for("CommandBar::unwrap"),d=[],s=localStorage.getItem("commandbar.lc"),u=s&&s.includes("local")?"http://localhost:8000":"https://api.commandbar.com",f=Object.assign(((n={})[r]={uuid:o},n[e]={},n[c]=!1,n[i]=!0,n[m]=newArray,n[l]=function(){returnf},n),a.CommandBar),p=["addCommand","boot"],y=f;Object.assign(f,{shareCallbacks:function(){return{}},shareContext:function(){return{}}}),a.CommandBar=newProxy(f,{get:function(o,n){returnniny?f[n]:p.includes(n)?function(){varo=Array.prototype.slice.call(arguments);returnnewPromise((function(a,t){o.unshift(n,a,t),f[m].push(o)}))}:function(){varo=Array.prototype.slice.call(arguments);o.unshift(n),f[m].push(o)}}}),null!==s&&d.push("lc=".concat(s)),d.push("version=2"),t("".concat(u,"/latest/").concat(o,"?").concat(d.join("&")),!0)}}void0===Object.assign||"undefined"==typeofSymbol||void0===Symbol.for?(a.__CommandBarBootstrap__=r,t("https://polyfill.io/v3/polyfill.min.js?version=3.101.0&callback=__CommandBarBootstrap__&features="+n)):r();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

alinashklyar reacted with thumbs up emoji
</p>
<divid="searchbar"></div>
<!-- <div id="searchbar"></div>-->
<button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

accessibility attributes for the button

yarn.lock Outdated
output-file-sync "^2.0.0"
slash "^1.0.0"
source-map "^0.5.0"
"@ampproject/remapping@^2.2.0":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this change caused byyarn upgrade or we have uncommitted changes?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

i ran 'yarn' command, anyway, i'll clear changes from here

@cf-ci-bot
Copy link

1 similar comment
@cf-ci-bot
Copy link

@cf-ci-bot
Copy link

@NimRegevNimRegev merged commite4d8fa0 intomasterMay 27, 2024
@NimRegevNimRegev deleted the CR-22957 branchMay 12, 2025 09:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@olegt-codefresholegt-codefresholegt-codefresh approved these changes

@NimRegevNimRegevAwaiting requested review from NimRegev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alinashklyar@cf-ci-bot@olegt-codefresh@NimRegev

[8]ページ先頭

©2009-2025 Movatter.jp