codefresh-io/docs.codefresh.ioPublic

NotificationsYou must be signed in to change notification settings
Fork165
Star21

Add section to reference shared config in YAML#715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

NimRegev merged 7 commits intomasterfromrefactor-shared-configuration

Jun 13, 2023

Merged

Add section to reference shared config in YAML#715

NimRegev merged 7 commits intomasterfromrefactor-shared-configuration

Jun 13, 2023

Conversation

Copy link

Contributor

NimRegev commentedJun 5, 2023

Added section to reference shared config and made content edits

Add section to reference shared config in YAML

0b12c91

Added section to reference shared config and made content edits

NimRegev requested a review fromThatAmatoGuy as acode owner

June 5, 2023 12:02

Copy link

cf-ci-bot commentedJun 5, 2023

[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/refactor-shared-configuration/docs/

daniel-codefresh suggested changes

Jun 7, 2023

View reviewed changes

_docs/pipelines/configuration/shared-configuration.md OutdatedShow resolvedHide resolved

Add reference shared config example to api

0517466

Moved referencing shared config context as example to pipeline API and added xref in shared config topic

Copy link

cf-ci-bot commentedJun 12, 2023

[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/refactor-shared-configuration/docs/

Update shared-configuration.md

03a0ab9

Added reference example to programmatic section with xrefs to CLI context command and full pipeline specifications

Copy link

cf-ci-bot commentedJun 12, 2023

[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/refactor-shared-configuration/docs/

Minor content edits

2d9fd5e

Copy link

cf-ci-bot commentedJun 12, 2023

[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/refactor-shared-configuration/docs/

NimRegev requested a review fromdaniel-codefresh

June 12, 2023 12:10

daniel-codefresh suggested changes

Jun 12, 2023

View reviewed changes

_docs/pipelines/configuration/shared-configuration.md

		You can also create/update/delete shared configuration via the[Codefresh CLI](https://codefresh-io.github.io/cli/) or[API]({{site.baseurl}}/docs/integrations/codefresh-api/).
		You can also create/update/delete shared configurations programmatically via the[Codefresh CLI](https://codefresh-io.github.io/cli/){:target="\_blank"} and the[Codefresh API]({{site.baseurl}}/docs/integrations/codefresh-api/).

		For example, you can reference one or more shared configuration contexts directly in the YAML using`spec.contexts` as described below.

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not sure i understand - how is this section relevant here? it begins with the words "For example" and describes how you can reference a shared configuration, when the paragraph before talks about create/update/delete operations on shared configurations which is a totally different thing.. Or am I missing something?