- Notifications
You must be signed in to change notification settings - Fork165
docs(runner): add units notice#658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cf-ci-bot commentedApr 16, 2023
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-17611/docs/ |
| |`userEnvVars`| object| Add external env var(s) to the pipeline. See [Custom Global Environment Variables](#custom-global-environment-variables) | | ||
| |`cluster`| object| k8s related information (`namespace`,`serviceAccount`,`nodeSelector`)| | ||
| |`resources`| object| Specify non-default`requests` and`limits`for engine pod| | ||
| |`resources`| object| Specify non-default`requests` and`limits`for engine pod. Units notice: only`Mi` allowedfor memory; only`m` allowedfor CPU| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggest changing for both:
For memory, useMi(mebibute); for CPU, usem (milli).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🙌 fixed!
cf-ci-bot commentedApr 16, 2023
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-17611/docs/ |
Uh oh!
There was an error while loading.Please reload this page.
This adds a notice that only
m(millicpu) allowed for CPU, and onlyMi(mebibyte) allowed for memory.Closes #CR-17611