- Notifications
You must be signed in to change notification settings - Fork165
Update push.md#394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update push.md#394
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Added new ECR fields role_arn, aws_session_name, and aws_duration_seconds to table
itai-codefresh commentedApr 6, 2022
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/classic-ecr-cross-accoubt-push/docs/ |
Changed from optional to default (optional params with defaults)
itai-codefresh commentedApr 6, 2022
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/classic-ecr-cross-accoubt-push/docs/ |
_docs/codefresh-yaml/steps/push.md Outdated
| |`candidate`| The identifier of the image to push to the remote Docker registry. It can be an explicit identifier of an image to push, or a variable that references a`Build` step.| Required| | ||
| |`tag`| The tag under which to push the image. Use either this or`tags`.<br> The default is`latest`.| Default| | ||
| |`region`| Relevant only for[Amazon ECR]({{site.baseurl}}/docs/integrations/docker-registries/amazon-ec2-container-registry/) integrations using either service accounts or explicit credentials. The names of the regions for which to perform cross-region replication. The names of the source region and the destination region name must be defined in separate steps.| Optional| | ||
| |`role_arn`| Relevant only for[Amazon ECR]({{site.baseurl}}/docs/integrations/docker-registries/amazon-ec2-container-registry/) integrations using either service accounts or explicit credentials. The role with the required permissions to use to pull the image. For example, `arn:aws:iam::<account-id>:role/<role-name>| Required| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It should be "optional". If the registry is not ECR then this field is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But we are assuming that it is ECR - we tell them that it's relevant only ECR registries and then it is required
itai-codefresh commentedApr 6, 2022
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/classic-ecr-cross-accoubt-push/docs/ |
Added new ECR fields role_arn, aws_session_name, and aws_duration_seconds to table