- Notifications
You must be signed in to change notification settings - Fork165
feat: Adding requested buttons to the primary nav.#358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: brandonLyonCf <brandon.lyon@codefresh.io>
Contributor
itai-codefresh commentedJan 14, 2022
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/blyon-add-version-buttons-to-nav/docs/ |
Signed-off-by: brandonLyonCf <brandon.lyon@codefresh.io>
Contributor
itai-codefresh commentedJan 14, 2022
[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/blyon-add-version-buttons-to-nav/docs/ |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: brandonLyonCfbrandon.lyon@codefresh.io
Per request from Noga, adding a button to the primary navigation that links to the other version of the docs site.
Note that the version of SASS used in the docs site is 4.7, which appears to require node version 8 (the current version is 17). I don't think I can compile CSS because it doesn't support recent versions of Mac OS. I tried using the docker method but that doesn't appear to compile SASS/CSS.
Long term we'll want to update the package versions. For now, I can try to style the requested v1/v2 navigation buttons using inline
<style>tags.