- Notifications
You must be signed in to change notification settings - Fork165
Updated Auto-Redirect Flow for Segments#1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
_includes/scripts.html Outdated
| <script> | ||
| constisEnterpriseDocumentationCookieSet=document.cookie.includes('cfdoctype=enterprise') | ||
| constcommandbarSegment=isEnterpriseDocumentationCookieSet ?'3033bf7f' :'43836ac3' | ||
| constcommandbarSegment=IS_ENTERPRISE_DOC_COOKIE_SET ?'3033bf7f' :'43836ac3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
do we still have this cookie?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I didn't rename itIS_GITOPS_DOC_COOKIE_SET - thank you!
| } | ||
| asyncfunctionhandleRedirect(){ | ||
| if(shouldSkipRedirect())return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if gitops cookie is removed, but user is trying to reach gitops page, we will not redirect him to enterprise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
At this stage, we will maintain a one-way redirect and extend it if necessary.
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-29569/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/CR-29569/docs/" |
5aa7985 intomasterUh oh!
There was an error while loading.Please reload this page.
No description provided.