- Notifications
You must be signed in to change notification settings - Fork165
Add segment switch to the header of a documentation site#1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/segment-switch/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/segment-switch/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/segment-switch/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/segment-switch/docs/" |
.gitignore Outdated
| .sass-cache/ | ||
| .jekyll-metadata | ||
| .jekyll-metadata | ||
| .qodo/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can't recognize this extension.
Can you please provide more details about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it's kind of AI assistant, like copilot. it randomly appeared in my webstorm and I put it into gitignore
| "no-descending-specificity": null, | ||
| "no-duplicate-selectors": true, | ||
| "number-leading-zero": "never", | ||
| "order/properties-order": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am not sure how linter works in the repo - let's have a sync on this change.
alinashklyarApr 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If any local changes don't match with linter rules, css is not compiled. Everytime I change anything in css, I need to spend extra minutes to manually align all properties accordingly to this rules and it became really annoying. I don't see any necessity in these rules, I think they are just wasting time
| <divclass="divider-vertical mt-1"></div> | ||
| <divclass="custom-select"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's make sure we add all accessibility attributes to this select component.
assets/scss/_divider.scss Outdated
| height:32px; | ||
| width:1px; | ||
| margin:016px; | ||
| background-color:#3f4255;// Adjust the color as needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's also connect it to a scss variable
_includes/argohub-docs-navbar.html Outdated
| <divclass="divider-vertical mt-1"></div> | ||
| <divclass="custom-select"> | ||
| <divclass="select-display"onclick="toggleSegmentDropdown()">GitOps Cloud</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's make sure this component looks as expected in Safari and Firefox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yes, it looks fine in both of them
_includes/argohub-docs-navbar.html Outdated
| <divclass="custom-select"> | ||
| <divclass="select-display"onclick="toggleSegmentDropdown()">GitOps Cloud</div> | ||
| <ulclass="options"> | ||
| <liclass="option selected"onclick="selectSegmentOption(this, 'gitops')">GitOps Cloud</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If this option selected - do we needonclick event on this option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(Can we setpointer-events: none for selected item?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
good point, thank you
| </div> | ||
| </a> | ||
| <divclass="divider-vertical mt-1"></div> | ||
| <divclass="custom-select"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same as the comments above.
_includes/scripts.html Outdated
| <script> | ||
| window.toggleSegmentDropdown=function(){ | ||
| constselect=document.querySelector('.custom-select'); | ||
| console.log(select) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's remove console.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sorry, I didn't notice it..
Uh oh!
There was an error while loading.Please reload this page.
assets/scss/_select.scss Outdated
| position:relative; | ||
| width:180px; | ||
| height:auto; | ||
| font-family:Arial,sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are we overriding docs page default font?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh, I will remove that. I trusted Copilot a bit too much
assets/scss/_variables.scss Outdated
| $grid-columns:12; | ||
| $grid-gutter-width-base:28px; | ||
| //ant inputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's add more specific comment like 'ANT design system:'
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/segment-switch/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/segment-switch/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/segment-switch/docs/" |
3fbf59f intomasterUh oh!
There was an error while loading.Please reload this page.
No description provided.