- Notifications
You must be signed in to change notification settings - Fork165
Gitops promotion hooks#1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
_docs/promotions/promotion-hooks.md Outdated
| export JIRA_ISSUE_BASE_URL="{{inputs.parameters.JIRA_BASE_URL}}" | ||
| export JIRA_ISSUE_SOURCE_FIELD="{{inputs.parameters.JIRA_ISSUE_SOURCE_FIELD}}" | ||
| PROMOTION_CONTEXT=$(echo "{\"JIRA_ISSUE_URL\": \"${JIRA_ISSUE_BASE_URL}/browse/${JIRA_ISSUE_SOURCE_FIELD}\"}") | ||
| echo "$PROMOTION_CONTEXT" > /tmp/promotion-context.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
again here the important part is the output param, need to add it to the example yaml as well
Uh oh!
There was an error while loading.Please reload this page.
_docs/promotions/promotion-hooks.md Outdated
| Expose the file with the promotion context as an output parameter to make it available to promotion mechanism. | ||
| * Add `PROMOTION_CONTEXT` as the `name` to `outputs.parameters`. _The name must not be changed_. | ||
| * Add the `globalName` attribute to make it available globally. The value must be identical to the name of the promotion context. | ||
| * `valueFrom` attribute to reference the file path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
potentially they can take it wherever they want from
Uh oh!
There was an error while loading.Please reload this page.
Edits after feedback from Dev
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
Added draft diagram for promotion context behavior and content updates
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
Added walkthrough example for promotion context
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
scme0 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just one minor comment from me. Looks good!
Uh oh!
There was an error while loading.Please reload this page.
Added example template to define promotion context and use in promotion hook
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
1 similar comment
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| * **Use a custom service account** | ||
| Use your own service account, and bind it to the default service role, `cf-default-promotion-workflows-role`. | ||
| ## Example of service account and service role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Example of a Service Account and a Role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Same as above; fixed the role but leaving in lowercase
Uh oh!
There was an error while loading.Please reload this page.
_docs/promotions/promotion-hooks.md Outdated
| Explore examples in [Codefresh Hub for Argo](https://codefresh.io/argohub/){:target="\_blank"}. | ||
| ##### Arguments in promotion hooks | ||
| A default set of arguments are available to all Promotion Workflows with hooksd. See [Default arguments in Promotion Workflows with hooks](#default-arguments-for-promotion-hooks). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hooksd --> hooks
_docs/promotions/promotion-hooks.md Outdated
| Explore examples in [Codefresh Hub for Argo](https://codefresh.io/argohub/){:target="\_blank"}. | ||
| ##### Arguments in promotion hooks | ||
| A default set of arguments are available to all Promotion Workflows with hooksd. See [Default arguments in Promotion Workflows with hooks](#default-arguments-for-promotion-hooks). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This link:[Default arguments in Promotion Workflows with hooks](#default-arguments-for-promotion-hooks).
doesn't work for me
_docs/promotions/promotion-hooks.md Outdated
| The table lists key differences between Promotion Workflows containing hooks and Promotion (Pre- and Post-Action) Workflows. | ||
| | **Feature** | **Promotion Hooks in Workflows** | **Pre- and Post-Action Workflows** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think that if we're making reference to "Pre- and Post-Action Workflows", then the second column should be "Promotion Hooks Workflows" (without thein)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, I had that in the beginning but changed it later. I think I'll add a heading Promotion Workflows and then two column headings below Promotion Hooks and Pre-and Post-Action
Uh oh!
There was an error while loading.Please reload this page.
Implemented feedback from Francisco's review
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
Added note on early access availability for publish
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
…esh-io/docs.codefresh.io into gitops-promotion-hooks
"[CI] Staging environment is athttp://staging-docs.codefresh.io.s3-website.us-east-1.amazonaws.com/gitops-auto-promotion-req/docs/" |
e643444 intomasterUh oh!
There was an error while loading.Please reload this page.
First dart of promotion hooks