- Notifications
You must be signed in to change notification settings - Fork18
chore(): updated base image to bookworm , updated kubectl#71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
vitalii-codefresh commentedJul 22, 2024
/e2e |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please ping devops on this
cf-deploy-kubernetes.sh Outdated
| if(( "$SERVER_VERSION"== "22"));then cp -f /usr/local/bin/kubectl1.22 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION">= "23"));then cp -f /usr/local/bin/kubectl1.23 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION"== "23"));then cp -f /usr/local/bin/kubectl1.23 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION">= "24"));then cp -f /usr/local/bin/kubectl1.30 /usr/local/bin/kubectl;fi2>/dev/null |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this needs to be30
Suggested change
| if(( "$SERVER_VERSION">= "24"));then cp -f /usr/local/bin/kubectl1.30 /usr/local/bin/kubectl;fi2>/dev/null | |
| if(( "$SERVER_VERSION">= "30"));then cp -f /usr/local/bin/kubectl1.30 /usr/local/bin/kubectl;fi2>/dev/null |
Dockerfile Outdated
| #copy all versions of kubectl to switch between them later. | ||
| COPY --chown=cfu --chmod=775 --from=builder /tmp/kubectl-versions/* /usr/local/bin/ | ||
| COPY --chown=cfu --chmod=775 --from=builder /tmp/kubectl-versions/kubectl1.10 /usr/local/bin/kubectl | ||
| COPY --chown=cfu --chmod=775 --from=builder /tmp/kubectl-versions/kubectl1.30 /usr/local/bin/kubectl |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please remove this
Comment on lines 17 to 20
| curl -o kubectl1.13 -L https://storage.googleapis.com/kubernetes-release/release/v1.13.0/bin/linux/${ARCH}/kubectl && \ | ||
| curl -o kubectl1.12 -L https://storage.googleapis.com/kubernetes-release/release/v1.12.0/bin/linux/${ARCH}/kubectl && \ | ||
| curl -o kubectl1.11 -L https://storage.googleapis.com/kubernetes-release/release/v1.11.0/bin/linux/${ARCH}/kubectl && \ | ||
| curl -o kubectl1.10 -L https://storage.googleapis.com/kubernetes-release/release/v1.10.0/bin/linux/${ARCH}/kubectl && \ |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please not remove them
ContributorAuthor
vitalii-codefresh commentedAug 13, 2024
/e2e |
Comment on lines +53 to +59
| if(( "$SERVER_VERSION"<= "7"));then cp -f /usr/local/bin/kubectl1.7 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION"<= "8"));then cp -f /usr/local/bin/kubectl1.8 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION"<= "9"));then cp -f /usr/local/bin/kubectl1.9 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION"<= "10"));then cp -f /usr/local/bin/kubectl1.10 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION"<= "11"));then cp -f /usr/local/bin/kubectl1.11 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION"<= "12"));then cp -f /usr/local/bin/kubectl1.12 /usr/local/bin/kubectl;fi2>/dev/null | ||
| if(( "$SERVER_VERSION"<= "13"));then cp -f /usr/local/bin/kubectl1.13 /usr/local/bin/kubectl;fi2>/dev/null |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we can skip adding the old versions
Dockerfile Outdated
Comment on lines 28 to 30
| curl -o kubectl1.9 -L https://storage.googleapis.com/kubernetes-release/release/v1.9.0/bin/linux/${ARCH}/kubectl && \ | ||
| curl -o kubectl1.8 -L https://storage.googleapis.com/kubernetes-release/release/v1.8.0/bin/linux/${ARCH}/kubectl && \ | ||
| curl -o kubectl1.7 -L https://storage.googleapis.com/kubernetes-release/release/v1.7.0/bin/linux/${ARCH}/kubectl && \ |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we can skip adding old versions
yaroslav-codefresh approved these changesAug 16, 2024
ContributorAuthor
vitalii-codefresh commentedAug 17, 2024
/e2e |
15 similar comments
ContributorAuthor
vitalii-codefresh commentedAug 17, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 17, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 17, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 19, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 19, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 19, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 20, 2024
/e2e |
ContributorAuthor
vitalii-codefresh commentedAug 21, 2024
/e2e |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Notes
Labels
Assign the following labels to the PR:
security- to trigger image scanning in CI buildPR Comments
Add the following comments to the PR:
/e2e- to trigger E2E build