Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Happy Number#51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
GouravRusiya30 merged 10 commits intocodedecks-in:masterfromifenil:master
Oct 3, 2020
Merged

Happy Number#51

GouravRusiya30 merged 10 commits intocodedecks-in:masterfromifenil:master
Oct 3, 2020

Conversation

@ifenil
Copy link
Contributor

@ifenilifenil commentedOct 2, 2020
edited
Loading

Pull Request Template

Description

A happy number is a number Starting with any positive integer, replace the number by the sum of the squares of its digits, and repeat the process until the number equals 1 if we get 1 so that number is Happy else not Happy.

Put check marks:

Have you made changes inREADME file ?

  • Added problem & solution under correct topic.
  • Specified Space & Time complexity.
  • Specified difficulty level, tag & Note(if any).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Make sure all below guidelines are followed else PR will get Reject:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code so that it is easy to understand
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@lokendra1704lokendra1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In Happy-Number.java, The use of HashSet can be avoided. Can you improve your solution?

ifenil reacted with thumbs up emoji
@ifenil
Copy link
ContributorAuthor

i made changes, now can you merge it

lokendra1704
lokendra1704 previously approved these changesOct 2, 2020
@ifenil
Copy link
ContributorAuthor

ifenil commentedOct 2, 2020
edited
Loading

I just made changes in readme file
what's happened it's asking for review again.

Copy link
Contributor

@lokendra1704lokendra1704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You repeated few names. Can you fix it?

@ifenil
Copy link
ContributorAuthor

Ok I check it

@lokendra1704
Copy link
Contributor

i made changes, now can you merge it

I like the new Solution 👌

ifenil reacted with thumbs up emoji

|[Girish Thatte](https://github.com/girishgr8/) <br> <imgsrc="https://github.com/girishgr8.png"width="100"height="100">| India| Java|[Leetcode](https://leetcode.com/girish13/) <br>[Hackerrank](https://www.hackerrank.com/procoder_13) <br>[Codechef](https://www.codechef.com/procoder_13)|
|[Kevin Chittilapilly](https://github.com/KevinChittilapilly) <br> <imgsrc="https://github.com/KevinChittilapilly.png"width="100"height="100">| India| Java|[Leetcode](https://leetcode.com/being_kevin/) <br>[Hackerrank](https://www.hackerrank.com/ckevinvarghese11) <br>[Kaggle](https://www.kaggle.com/kevinchittilapilly)|
|[Nour Grati](https://github.com/Nour-Grati) <br> <imgsrc="https://github.com/Nour-Grati.png"width="100"height="100"> | Tunisia | Python |[Leetcode](https://leetcode.com/nourgrati/) <br>[Hackerrank](https://www.hackerrank.com/noor_grati) <br>[Twitter](https://twitter.com/GratiNour1)
|[Avinash Trivedi](https://github.com/trivediavinash) <br> <imgsrc="https://github.com/trivediavinash.png"width="100"height="100">| India| C++|[Leetcode](https://leetcode.com/avi_002/)|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

and this one too

lokendra1704
lokendra1704 previously approved these changesOct 2, 2020
@ifenil
Copy link
ContributorAuthor

Ok I do it

@ifenil
Copy link
ContributorAuthor

ifenil commentedOct 2, 2020
edited
Loading

now it's solved can you pls check it
And merge it

@ifenil
Copy link
ContributorAuthor

Why it's not merge yet?

@lokendra1704
Copy link
Contributor

Why it's not merge yet?

Only@GouravRusiya30 can merge the requests. He might be busy. Don't worry, It will get merged soon.

ifenil reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lokendra1704lokendra1704Awaiting requested review from lokendra1704

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ifenil@lokendra1704@GouravRusiya30

[8]ページ先頭

©2009-2025 Movatter.jp