Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update rubocop to 1.75.2#374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
BrianHawley wants to merge1 commit intocodeclimate:channel/beta
base:channel/beta
Choose a base branch
Loading
fromBrianHawley:updates_rubocop_1-68-0

Conversation

BrianHawley
Copy link

  • General bundle update.
  • Update the docs too.
  • Fix rubocop API deprecations.
  • Fix reasonable rubocop complaints.
  • Disable unnecessary rubocop complaints.
  • Explicit ostruct dependency for future compatibility.
  • Remove an unnecessary empty file.

sallesma, alexrolopez, kaiserbrito, and s-scheele-simonsen reacted with thumbs up emojikstevens715 and s-scheele-simonsen reacted with hooray emojibrunolarouche and s-scheele-simonsen reacted with heart emoji
@BrianHawley
Copy link
Author

@f-moya could you merge this one? It's has a bundle update and rake docs:scrape, but it also fixes the rubocop failures in the code itself, and all of the new rubocop API deprecation warnings in the new version.

@f-moya
Copy link

Hi@BrianHawley, I hope you're doing well. I am no longer with Code Climate, so I won't be able to assist with the deployments moving forward.

@BrianHawley
Copy link
Author

@f-moya do you know whose job it is at Code Climate to review and merge these PRs? So I can tag them when I make these updates.

@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.68.0Update rubocop to 1.69.0Dec 2, 2024
@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.69.0Update rubocop to 1.69.1Dec 3, 2024
@kstevens715
Copy link

Getting this released would be a big help to me. I'm using ruby-lsp and Neovim and it sounds like this should fix the issue according to:Shopify/ruby-lsp#2840 (comment)

@gfguthrie
Copy link

@BrianHawleystandard 1.43.0 supportsrubocop 1.69.1 – any thoughts on adding it back in for this channel? Would you accept a PR to your PR if I figured it out?

@BrianHawley
Copy link
Author

BrianHawley commentedDec 18, 2024
edited
Loading

@gfguthrie I checked with the standard people and they were pretty clear that they have no intention to keep their development in sync with that of rubocop, as it's (understandably) too much work. So if it's temporarily in sync, we can't assume that this will continue. It would be a bad precedent to add standard back to the regular rubocop channel when we'd need to remove it again in the near future, when they get out of sync again.

It still is the best approach to have a separate set of standard channels, with a separate standard beta channel that would have the latest standard and the latest rubocop that standard supports. As I mentioned before in#357.

gfguthrie and kaiserbrito reacted with thumbs up emoji

@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.69.1Update rubocop to 1.69.2Dec 18, 2024
@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.69.2Update rubocop to 1.70.0Jan 21, 2025
@BrianHawleyBrianHawleyforce-pushed theupdates_rubocop_1-68-0 branch 2 times, most recently from4f05136 to1380afdCompareJanuary 23, 2025 17:34
@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.70.0Update rubocop to 1.71.0Jan 23, 2025
@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.71.0Update rubocop to 1.71.2Feb 5, 2025
@kbrock
Copy link

kbrock commentedMar 1, 2025
edited
Loading

rubocop is up to 1.73 (2/27/2025)
Getting a channel for a recent version of rubocop would be great

defaults version is 0.52.1 (code climate docs - released 12/27/2017)

And the latest rubocop from code climate is 1.56.3 (code climate docs - released 9/11/2023)


Also, please share any suggestions on how we can make it easier to get a more recent version of rubocop into the channels.

I figure it will take us work to upgrade configuration for rubocop. Maybe we can share some of the work?

@kbrock
Copy link

@BrianHawley Would it make sense to target 1.72.x or 1.73.x?

I have yet to fully understand the new plugin mechanism, but it may be nice to support this for others.ref

I guess on that note, maybe targeting 1.71.x is the way to go. It works like it has always worked.

Not sure your use case and your use of rubocop plugins.

@BrianHawley
Copy link
Author

BrianHawley commentedMar 7, 2025
edited
Loading

@kbrock it's updated. But I still don't know which GitHub user account to tag to get these PRs merged. The previous person no longer has merge privileges, as mentioned above.

My use case is that I need up-to-date rubocop, which is why I had them create the beta channel, and why I make these PRs. However, I do these updates manually, and I didn't have the time recently.

The existing rubocop version in Codeclimate works withrequire statements. The plugin versions of rubocop will also work withrequire statements, for now: though they complain, those complaints don't cause rubocop to fail. So I'd recommend sticking withrequire statements until someone with merge privileges shows up.

kaiserbrito reacted with thumbs up emoji

@kbrock
Copy link

Thanks for the update@BrianHawley

We're running into problems because the old code climate references rexml (which has had a bunch of CVEs recently) and references other libraries that we want to upgrade.

Would be cool to have a full fledged channel for various rubocop versions, but great job getting the beta channel into place.

I'll see if we have any contacts at code climate. It is hard for an organization to support so many programming languages.

@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.71.2Update rubocop to 1.74.0Mar 17, 2025
@kirylrb
Copy link

Could anyone merge it ?

- General bundle update.- Update the docs too.- Fix rubocop API deprecations.- Fix reasonable rubocop complaints.- Disable unnecessary rubocop complaints.- Explicit ostruct dependency for future compatibility.- Remove an unnecessary empty file.
@BrianHawleyBrianHawley changed the titleUpdate rubocop to 1.74.0Update rubocop to 1.75.2Apr 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sbsurfsbsurfsbsurf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@BrianHawley@f-moya@kstevens715@gfguthrie@kbrock@kirylrb@sbsurf

[8]ページ先頭

©2009-2025 Movatter.jp