- Notifications
You must be signed in to change notification settings - Fork45
Fix CircleCI configuration#339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:channel/beta
Are you sure you want to change the base?
Fix CircleCI configuration#339
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e846427 to7b384f9CompareCircleCI sent me an email indicating that the config settings for thisrepo were set to use a deprecated image (Ubuntu 14.04) because we didn'tspecify the image to use.The image option is required, per their docs; set it as recommended.
7b384f9 to5e6364aCompare@fede-moya or@filipesperandio could you review and merge? This should also be able to be cherry-picked to other new channels, though they really should be based on channel/beta anyways so that shouldn't be a problem. The particular setting only affects the process of creating a new version of the engine image in docker, and only affects the host process that is building the image. It doesn't affect the built image itself, which is based on Dockerfile instead of this config. |
@fede-moya this change is still needed. Could you review? |
CircleCI sent me an email indicating that the config settings for this repo were set to use a deprecated image (Ubuntu 14.04) because we didn't specify the image to use.
The image option is required, per their docs; set it as recommended.