- Notifications
You must be signed in to change notification settings - Fork8
Upgrade codeclimate-pmd#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Dockerfile Outdated
| @@ -5,6 +5,7 @@ MAINTAINER "Code Climate <hello@codeclimate.com>" | |||
| USER root | |||
| RUN apk update && \ | |||
| apk add --no-cache bash && \ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Couldn't get the image to build or CI to pass without adding this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Presumably because the base image used to havebash installed and probably got updated to only havesh (which is more normal for alpine images).
I don't think we reallyneed bash, and we could probably rewriteinstall-pmd.sh to use pure POSIX shell, but it's probably not worth it and this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would addingbash to the next line without the--no-cache option work just as well?
Dockerfile Outdated
| @@ -5,6 +5,7 @@ MAINTAINER "Code Climate <hello@codeclimate.com>" | |||
| USER root | |||
| RUN apk update && \ | |||
| apk add --no-cache bash && \ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Presumably because the base image used to havebash installed and probably got updated to only havesh (which is more normal for alpine images).
I don't think we reallyneed bash, and we could probably rewriteinstall-pmd.sh to use pure POSIX shell, but it's probably not worth it and this is fine.
dblandin left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Minor question. LGTM either way.
This upgrades the codeclimate-pmd engine from 6.0.1 to 6.7.0.
ea71ac1 todcf8ae4Compare
Uh oh!
There was an error while loading.Please reload this page.
codeclimate-pmdengine6.7.0