- Notifications
You must be signed in to change notification settings - Fork23
QUA-514: update packages and fix sniff-related user errors#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f-moya commentedFeb 23, 2022
@dantevvp sorry I missed this one, will review tomorrow |
f-moya commentedMar 14, 2022
dafeder commentedMay 2, 2022
Hey @fede-moya we just started seeing the "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" error on our beta builds... possible there was something in here that was still needed? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates some of the composer requirements while fixing errors reported by users after the latest image update.
Description
Added
php7-xmlreaderextensionFixes error:
Class 'XMLReader' not found in /usr/src/app/vendor/wp-coding-standards/wpcs/WordPress/Sniffs/WP/I18nSniff.phpAdded
/usr/src/app/vendor/slevomat/coding-standardtophpcs's configinstalled_pathsFixes error:
Referenced sniff "SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator" does not existUpdated
pheromone/phpcs-security-auditto version 2.0.1Fixes error:
Exception: Interface 'PHP_CodeSniffer_Sniffs' not foundAdded command to copy
MEQPfolder insideMEQP1folder inmagento/marketplace-eqppackageFixes error:
Trait 'MEQP\Utils\Helper' not foundIssue reference
https://codeclimate.atlassian.net/browse/QUA-514