- Notifications
You must be signed in to change notification settings - Fork23
Update PHP Codesniffer#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
f-moya commentedSep 27, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Seems like I don't have the enough permissions for requesting your review, that's why I ping you here. Also, you will noticed the I have changed the base docker image I addressed as CC issues as I could, there are some remaining that have been here for a long time, so I think we could temporary ignored them. One more thing, my idea is to create a One more other thing 😆 , I think we could include this workhttps://github.com/codeclimate/codeclimate-phpcodesniffer/pull/80/files into the release of the |
filipesperandio commentedSep 29, 2020
Permissions granted, no need the fork either anymore.
👍 will look at Circle CI now. |
filipesperandio commentedSep 29, 2020
I think the circle issue is due to the fork. we don't allow it to pass in credentials to forked PRs. |
filipesperandio commentedSep 29, 2020
Seems like we can only change base branch... so maybe a new one? |
filipesperandio commentedSep 29, 2020
|
filipesperandio commentedSep 29, 2020
#80 merged into |
@filipesperandio done ! 💪🏼 |
Replaced by#83 |
Uh oh!
There was an error while loading.Please reload this page.
The main purpose of the work is to allow users to run the PSR12 standard.
Sharing here some resources that have been super helpful to address this update and might be useful again in the future. Changes like renaming the old
Runner.phptoExecutor.phpand the rest of the changes can be easily understood by taking a quick look to the links shared below.