Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update PHP Codesniffer#82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
f-moya wants to merge3 commits intocodeclimate:masterfromf-moya:master
Closed

Conversation

@f-moya
Copy link

@f-moyaf-moya commentedSep 27, 2020
edited
Loading

The main purpose of the work is to allow users to run the PSR12 standard.

Sharing here some resources that have been super helpful to address this update and might be useful again in the future. Changes like renaming the oldRunner.php toExecutor.php and the rest of the changes can be easily understood by taking a quick look to the links shared below.

@f-moya
Copy link
Author

f-moya commentedSep 27, 2020
edited
Loading

@filipesperandio

Seems like I don't have the enough permissions for requesting your review, that's why I ping you here.

Also, you will noticed the I have changed the base docker imagealpine:edge to an specific version. While using thealpine:edge image I suffered from different dns resolutions problems which were not allowing a successfulcompose install, it wasn't able to fetch certain packages. After hours of checking if those packages existed and other potential explanations I ended up changing the base image and it started to work. I didn't perform any further research on that due to the fact that we are a little bit tight regarding schedule.

I addressed as CC issues as I could, there are some remaining that have been here for a long time, so I think we could temporary ignored them.

One more thing, my idea is to create abeta channel for this plugin so I think it would be nice to merge this work against abeta branch. Could you create that branch please ? 🙏🏼

One more other thing 😆 , I think we could include this workhttps://github.com/codeclimate/codeclimate-phpcodesniffer/pull/80/files into the release of thebeta channel. WDYT ?, after merging this one I can rebase that one, test it and update that pr to point tobeta. And do you have an idea of whyci/circleci is being displayed as pending 🤔 ?

@filipesperandio
Copy link

Seems like I don't have the enough permissions for requesting your review, that's why I ping you here.

Permissions granted, no need the fork either anymore.

Also, you will noticed the I have changed the base docker image alpine:edge to an specific version. While using the alpine:edge image I suffered from different dns resolutions problems which were not allowing a successful compose install, it wasn't able to fetch certain packages. After hours of checking if those packages existed and other potential explanations I ended up changing the base image and it started to work. I didn't perform any further research on that due to the fact that we are a little bit tight regarding schedule.

👍

will look at Circle CI now.

@filipesperandio
Copy link

I think the circle issue is due to the fork. we don't allow it to pass in credentials to forked PRs.
Now that you have permissions for the repo, can we try pushing a non-forked branch and update the PR? (I don't recall doing it, not sure we can or a new PR is needed)

@filipesperandio
Copy link

Seems like we can only change base branch... so maybe a new one?

@filipesperandio
Copy link

beta created

@filipesperandio
Copy link

#80 merged intobeta

@f-moya
Copy link
Author

@filipesperandio done ! 💪🏼

filipesperandio reacted with hooray emoji

@f-moya
Copy link
Author

Replaced by#83

@f-moyaf-moya closed thisSep 30, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@f-moya@filipesperandio

[8]ページ先頭

©2009-2025 Movatter.jp