Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update PHPCS to 3.5 and update all standards#76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
filipesperandio merged 2 commits intocodeclimate:betafromLaizerox:update-phpcs
Sep 29, 2020

Conversation

@Laizerox
Copy link

@LaizeroxLaizerox commentedNov 1, 2019•
edited
Loading

Migrated PHPCS from 2.9 to 3.0+.

PHPCS changed some runner / CLI code and its now migrated. Basic standards PSR1, PSR2, PSR12 are tested and they work. Also quick tests on Symfony and Magento2 were performed.

This PR also updates all standards to highest version available / compatible with latest PHPCS and introduces new Magento2 standard as it was split from old repo.

This PR is related to#75 report.

lxlang, abenevaut, nextdayflight, and brianlack reacted with thumbs up emojidoMynation reacted with eyes emoji
@abenevaut
Copy link

PSR12 is coming! NICE!!!!

@doMynation
Copy link

Hi,

Thecurrent version used by CodeClimate is severely out of date, and yields a bunch of false positives due to it not being able to parse the latest additions to the PHP language (e.g.flexible heredoc). These false positives are blocking our CI/CD pipeline and basically render CodeClimate unusable for us at the moment.

With that being said, is there any plan to merge and deploy this PR?

Thank you very much.

brianlack, doMynation, and sguerrabSV reacted with thumbs up emoji

@abenevaut
Copy link

@doMynation, I changed for github actions for codestyle and i'm now usinghttps://codecov.io/ for coverage.

@filipesperandiofilipesperandio changed the base branch frommaster tobetaSeptember 29, 2020 17:27
@filipesperandiofilipesperandio merged commit8b7d12e intocodeclimate:betaSep 29, 2020
@filipesperandio
Copy link

@Laizerox thanks for this. Sorry it took us so long to act.
Just merged intobeta, we are releasing achannel: beta next, so it will require to tune.codeclimate.yml to use that instead.

@doMynationdoMynation mentioned this pull requestOct 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@abenevautabenevautabenevaut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Laizerox@abenevaut@doMynation@filipesperandio
[8]ページ先頭
©2009-2025 Movatter.jp