This repository was archived by the owner on Jul 19, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork24
Upgrade to latest versions offlay andsexp_processor#383
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This applies a small monkey patch to the `parse_sexp` method in the`sexp_processor` gem. This will allow us to continue passing filters to`Sexp::Matcher.parse` like this:```DEFAULT_FILTERS = [ "(UsingDirective ___)".freeze].freeze```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@larkinscott have you confirmed ?
Note: I'm still confirming if the line number changes from this update make sense.
RubyBrewsday approved these changesDec 5, 2023
larkinscott added a commit that referenced this pull requestDec 18, 2023
…)"This reverts commitfcdaf4a.
larkinscott added a commit that referenced this pull requestMar 19, 2024
…)"This reverts commitfcdaf4a.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This also applies a small monkey patch to the
parse_sexpmethod in thesexp_processorgem. This will allow us to continue passing filters toSexp::Matcher.parselike this:Note: I'm still confirming if the line number changes from this update make sense.