- Notifications
You must be signed in to change notification settings - Fork24
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Skipping CI for those, how we are going to validate them instead?
f-moya commentedAug 20, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@filipesperandio it's not the entire ci, just the job for releasing images. Do you think releasing images is a necessary step for validating prs ? |
🤦 I was tired... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I am OK shipping this anyways, but seems like we only actually release images for master and channel-* branches here:https://github.com/codeclimate/codeclimate-duplication/blob/master/bin/deploy#L10-L13
f-moya commentedAug 20, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
mmmm, interesting because it is getting triggered on#364 |
6205888 to109177cCompare…ter and channel branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, that build seems to break ondocker login, even before thebin/deploy call, but I agree this is even better as we skip the step entirely, have CIRCLE env vars checked on Circle related files and make it more visible.
👍
@filipesperandio Exactly it was breaking before the |
Uh oh!
There was an error while loading.Please reload this page.
We are receiving failed builds from prs open by the community due to running the
relase-imagesci job. This work removes this job for those cases.See#364