Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Bump parser to b859#362

Merged
nporteschaikin merged 2 commits intocodeclimate:masterfromf-moya:bump-parser-b859
Mar 15, 2021

Conversation

f-moya
Copy link
Contributor

AsBump PHP parser indicates a major update has been done to the main library in charge of parsing php code into AST nodes.

There are some differences between the old and new php parser, the differences are mostly new nodes, as you can check in it'sCHANGELOG. This new nodes have increased the resulting AST depth, which has forced us to modify both theDEFAULT_MASS_THRESHOLD andPOINTS_PER_OVERAGE in order to avoid overwhelming existent users with new issues.

The approach that we have taken for manipulating this constants has been: "Avoid generating new issues for customers". Also, we did research about which was the approach used in the project for this kind of changes and seems like they were very empirical based. Being said that, I propose to try this settings and came back if we have any customer's reports about this.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees

@filipesperandiofilipesperandio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@f-moya@filipesperandio@nporteschaikin

[8]ページ先頭

©2009-2025 Movatter.jp