This repository was archived by the owner on Jul 19, 2025. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork24
Ignore PHP namespace statements#328
Open
tillkruss wants to merge1 commit intocodeclimate:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The CircleCI tests are don't seem to be working:https://circleci.com/gh/codeclimate/codeclimate-duplication Any tips@larkinscott? |
Any feedback on this PR@toddmazierski@brynary? |
👋@tillkruss Thanks for the PR! This seems reasonable to me. Looking into this CI failure now. |
@tillkruss Thanks for bringing that CI failure to our attention. This should be fixed now if you rebase on top of master. |
@larkinscott I rebased the branch, but now other tests are failing: Both fail due to: I assume the issue previously was the namespace and my PR eliminates the issue? |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
We're seeing hundreds of code duplication warnings for namespace statements.
#245 didn't include the actual
namespacestatements and this PR covers the case when there is a space between thenamespaceanduseblocks.