Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork742
Draft: Migrate to esm#4229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:4.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
130d797 to1c790eeCompare@kobenguyent we should create 4.x branch and push it into this new branch |
@DavertMik done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot reviewed 401 out of 402 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .eslintrc.json: Language not supported
Comments suppressed due to low confidence (2)
lib/cli.js:24
- [nitpick] There is an apparent inconsistency in how the output module is referenced. Consider standardizing the usage (e.g., either always use 'output' or 'output.output') to avoid potential confusion.
output.output.level(level);lib/assert/equal.js:27
- [nitpick] The call to 'output.colors.bold' is inconsistent with similar patterns in other files that use 'output.output.colors.bold'. Consider unifying the approach to maintain consistent module usage across the assertions.
const msg = err.template.replace('{{jar}}', output.colors.bold('{{jar}}'));
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)