Commitdb6df39

msaelices

authored and

rigor789

committed

fix: action bar rendering - issuenativescript-vue#276 (nativescript-vue#278)

* Fix the app-with-pages.js sample by adding a Frame root element and add two action bars in order to reproduce the issuenativescript-vue#276.* Fix page composition when does navigation issue (nativescript-vue#276), which wraps an already Page component in another Page component, losing its action bar.

1 parent8f2d1a7 commitdb6df39Copy full SHA for db6df39

File tree

2 files changed

+16

-4

lines changed

platform/nativescript/util
- index.js
samples/app
- app-with-pages.js

2 files changed

+16

-4

lines changed

`‎platform/nativescript/util/index.js`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export function isUnknownElement(el) {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`exportfunctionisPage(el){`
`34`		`-returnel&&el.tagName==='page'`
	`34`	`+returnel&&el.tagName==='nativepage'`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`/*@deprecated /`

`‎samples/app/app-with-pages.js`

Lines changed: 15 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,16 @@ const Vue = require('./nativescript-vue')`
`2`	`2`
`3`	`3`	`constApp={`
`4`	`4`	template:`
`5`		`- <StackLayout>`
`6`		`- <Button text="Open page" @tap="openPage" />`
`7`		`- </StackLayout>`
	`5`	`+ <Frame>`
	`6`	`+ <Page>`
	`7`	`+ <ActionBar class="action-bar" title="Home Page">`
	`8`	`+ <ActionItem text="Action"></ActionItem>`
	`9`	`+ </ActionBar>`
	`10`	`+ <StackLayout>`
	`11`	`+ <Button text="Open page" @tap="openPage" />`
	`12`	`+ </StackLayout>`
	`13`	`+ </Page>`
	`14`	`+ </Frame>`
`8`	`15`	`,
`9`	`16`
`10`	`17`	`methods:{`
`@@ -16,11 +23,16 @@ const App = {`
`16`	`23`
`17`	`24`	`constDetailsPage={`
`18`	`25`	template:`
	`26`	`+ <Page>`
	`27`	`+ <ActionBar class="action-bar" title="Details Page">`
	`28`	`+ <ActionItem text="Action"></ActionItem>`
	`29`	`+ </ActionBar>`
`19`	`30`	`<StackLayout>`
`20`	`31`	`<Label :text="'Details ' + Math.random()" />`
`21`	`32`	`<Button text="another" @tap="openDetails" />`
`22`	`33`	`<Button text="back" @tap="goBack" />`
`23`	`34`	`</StackLayout>`
	`35`	`+ </Page>`
`24`	`36`	`,
`25`	`37`
`26`	`38`	`methods:{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdb6df39

File tree

2 files changed

2 files changed

`‎platform/nativescript/util/index.js`

`‎samples/app/app-with-pages.js`

0 commit comments