- Notifications
You must be signed in to change notification settings - Fork7.1k
Fix issue #20608 - Fix compile error on MacOSX big sur#20696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Riyaaaaa wants to merge1 commit intococos2d:v3Choose a base branch
base:v3
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
Riyaaaaa commentedNov 26, 2021
I faced this issue when building my project as MacOSX application, but it is also possible to occur on iOS application if you are using cmake. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixed:#20608
Maybe related:#20435
environment
OS: MacOSX 11.3 big sur
Xcode: 13.1
cmake: 3.21.2
description
Compile errors occurred when Xcode project is generated from cmake on MacOSX big sur.
clang: error: no such file or directory: '/usr/lib/libiconv.dylib'Bacause iconv path is resolved by find_library in CocosConfigDepend.cmake as below.
find_library(ICONV_LIBRARY iconv)But ICONV_LIBRARY always be set
/usr/lib/libconv.dylibignoring sys_root. /usr/lib seems to be no longer available and it is located at/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/usr/lib/libiconv.tbdon big sur.I guess ICONV_LIBRARY is already defined by cmake system so find_library do nothing.
https://cmake.org/cmake/help/latest/module/FindIconv.html
solution
I used other name so that avoid conflicting name.