Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Re-factor the build script to distinguish each step#2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DRSDavidSoft merged 28 commits intocmderdev:masterfromDRSDavidSoft:master
Oct 17, 2022

Conversation

@DRSDavidSoft
Copy link
Contributor

@DRSDavidSoftDRSDavidSoft commentedOct 16, 2022•
edited
Loading

This PR addresses#2757

Description

  • Added a-noVendor switch to bypass downloading vendor packages
  • Only check formsbuild.exe in path when the-Compile switch is used

👉Note: The order of build has changed. Previously, the vendor packages were downloaded first, and then the launcher was subsequently built.

Since the launcher doesn't depend on vendored packages, and it might fail first, this PR moves the build stepbefore downloading files, so if it fails the vendored files aren't downloaded and discarded.

@DRSDavidSoft
Copy link
ContributorAuthor

DRSDavidSoft commentedOct 16, 2022•
edited
Loading

@daxgames Please have a look, thanks!

📦Download from GitHub Actions:https://github.com/cmderdev/cmder/actions/runs/3259741744

@daxgames
Copy link
Member

@DRSDavidSoft are you adding Githubgh as a Cmder component? If so I like it.

@DRSDavidSoft
Copy link
ContributorAuthor

@DRSDavidSoft are you adding Githubgh as a Cmder component? If so I like it.

That's also a good idea, but those functions are for the GitHub Actions / CI. I thinkgh could also be useful since it's only ~8 MB, but not the focus of this PR.

@daxgames
Copy link
Member

daxgames commentedOct 16, 2022•
edited
Loading

I could see addinggh to the%CMDER_ROOT%/vendor/bin folder so it is automatically in the path. At this point it is easy enough to add after by a user that wants it.

DRSDavidSoft reacted with thumbs up emoji

@daxgames
Copy link
Member

daxgames commentedOct 16, 2022•
edited
Loading

Odd it downloads from Github actions asCmder.zip.zip and it is a zip in a zip.

@DRSDavidSoft
Copy link
ContributorAuthor

@daxgames Sad to say, this is a known limitation by the authors (https://github.com/actions/upload-artifact#zipped-artifact-downloads). I haven't found anything yet to overcome this

@DRSDavidSoftDRSDavidSoft merged commit5eacfc9 intocmderdev:masterOct 17, 2022
@DRSDavidSoftDRSDavidSoft self-assigned thisJun 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@DRSDavidSoftDRSDavidSoft

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DRSDavidSoft@daxgames
[8]ページ先頭
©2009-2025 Movatter.jp