Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix build system scripts (closes #2723)#2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
daxgames merged 12 commits intocmderdev:masterfromDRSDavidSoft:master
Sep 11, 2022

Conversation

@DRSDavidSoft
Copy link
Contributor

@DRSDavidSoftDRSDavidSoft commentedSep 10, 2022
edited
Loading

Description

This PR updates some build properties in order to fix both the AppVeyor builds and also the build scripts running on a local machine.

I plan to work on a GitHub Actions PR in order to either replace AppVeyor or run GitHub Actions alongside it.

Note

Please first merge the following PRs, as this one contains commits from those as well:

Status

Closes#2723

Thanks! 😄

@DRSDavidSoftDRSDavidSoft changed the titleFix build system scriptsFix build system scripts (closes #2723)Sep 10, 2022
@daxgamesdaxgames merged commit3d0e6b8 intocmderdev:masterSep 11, 2022
@daxgames
Copy link
Member

@DRSDavidSoft Thanks and merged.

DRSDavidSoft reacted with heart emoji

@daxgames
Copy link
Member

@DRSDavidSoft build is still failing. although it worked fine for me on my local system.

@MartiUK any changes required for the appveyor job that I think you own to make these changes work to fix the build scripts.

@DRSDavidSoft
Copy link
ContributorAuthor

@daxgames I think it's time to add me as the cmder core dev teams. I'd like to ask for the same permissions as a maintainer, and also to the AppVeyor CI dashboard. I'll fix everything as needed in order to make the build system functional again.

Also, please give me permissions so I can set up GitHub actions, and also update issues templates.

Other than that, the build system is working on my forks:
https://ci.appveyor.com/project/DRSDavidSoft/cmder

@daxgames
Copy link
Member

daxgames commentedOct 9, 2022
edited
Loading

@DRSDavidSoft I don't even have access to the appveyor stuff that is why I asked@MartiUK about it.

While I am currently the most active here I don't know if it is my call to give the access you request. If the rest of the @cmderdev/trusted-contributors agree I am all for it.

@MartiUK is currently working on github actions but he may be willing to turn it over to you.

Stanzilla and DRSDavidSoft reacted with thumbs up emoji

@MartiUK
Copy link
Member

@DRSDavidSoft Apologies, I thought you already were a trusted contributor. I've invited you, you're welcome to continue on with the changes to appveyor etc.

DRSDavidSoft reacted with heart emoji

@DRSDavidSoft
Copy link
ContributorAuthor

DRSDavidSoft commentedOct 14, 2022
edited
Loading

@MartiUK Thanks for granting the permission, I already created the GitHub Actions workflow for building Cmder (more in#2725 (comment)). However, there is still an issue with AppVeyor:

I have yet again limited functionality to apply adjustments to the repo's CI settings (beside GitHub actions), and I don't have access to the AppVeyor settings (in the MartiUK account):

https://ci.appveyor.com/project/MartiUK/cmder

image

✔️https://ci.appveyor.com/project/DRSDavidSoft/cmder

For reference, the sameappveyor.yml config file and the same repo builds correctly on my AppVeyor instance:

Image

I would appreciate it if you could either grant me access to your fork of Cmder on AppVeyor, or changeEnvironmentBuild worker image toVisual Studio 2019, or allow me to useappveyor.com/project/DRSDavidSoft instead ofappveyor.com/project/MartiUK in the cmder repo.

This will require adding back the AppVeyor marketplace app to the GitHub repo, which I'd appreciate if either you could do it, or grant me the required permissions in order for me to install it.

Thanks! 👍🏻

@DRSDavidSoft
Copy link
ContributorAuthor

@MartiUK I would also appreciate it if you could send an screenshot of the following settings in your AppVeyor panel:

image

@daxgames
Copy link
Member

It would be great if we all had access tonthe Appveyor stuff if possible.

DRSDavidSoft reacted with thumbs up emoji

@DRSDavidSoft
Copy link
ContributorAuthor

@daxgames There is documentation regarding how to set up an organization with proper access to team mebers:
https://www.appveyor.com/docs/team-setup/

@DRSDavidSoft
Copy link
ContributorAuthor

Tracking in#2734

@MartiUK
Copy link
Member

I've enabled team access to appveyor, hopefully you guys can just login with github on appveyor and you'll have access

@MartiUK
Copy link
Member

@MartiUK I would also appreciate it if you could send an screenshot of the following settings in your AppVeyor panel:

image

They are exactly as you have them there

@MartiUK
Copy link
Member

@MartiUK Thanks for granting the permission, I already created the GitHub Actions workflow for building Cmder (more in#2725 (comment)). However, there is still an issue with AppVeyor:

I have yet again limited functionality to apply adjustments to the repo's CI settings (beside GitHub actions), and I don't have access to the AppVeyor settings (in the MartiUK account):

https://ci.appveyor.com/project/MartiUK/cmder

image

https://ci.appveyor.com/project/DRSDavidSoft/cmder

For reference, the sameappveyor.yml config file and the same repo builds correctly on my AppVeyor instance:

Image

I would appreciate it if you could either grant me access to your fork of Cmder on AppVeyor, or changeEnvironmentBuild worker image toVisual Studio 2019, or allow me to useappveyor.com/project/DRSDavidSoft instead ofappveyor.com/project/MartiUK in the cmder repo.

This will require adding back the AppVeyor marketplace app to the GitHub repo, which I'd appreciate if either you could do it, or grant me the required permissions in order for me to install it.

Thanks! 👍🏻

Set worker image to VS 2019

@DRSDavidSoft
Copy link
ContributorAuthor

image

Unfortunately, now no one can access the project (signed-in or signed-out):
https://ci.appveyor.com/project/MartiUK/cmder

@MartiUK
Copy link
Member

It has been renamed to:https://ci.appveyor.com/project/cmderdev/cmder

DRSDavidSoft reacted with thumbs up emoji

@cmderdevcmderdev deleted a comment fromdaxgamesMay 14, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

@DRSDavidSoftDRSDavidSoft

Projects

None yet

Milestone

1.3.22

Development

Successfully merging this pull request may close these issues.

Cmder build is failing

3 participants

@DRSDavidSoft@daxgames@MartiUK

[8]ページ先頭

©2009-2025 Movatter.jp